From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Clemens Ladisch" <clemens@ladisch.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Brad Campbell" <lists2009@fnarfbargle.com>,
"Ondrej Čerman" <ocerman@sda1.eu>,
"Bernhard Gebetsberger" <bernhard.gebetsberger@gmx.at>,
"Holger Kiehl" <Holger.Kiehl@dwd.de>,
"Michael Larabel" <michael@phoronix.com>,
"Jonathan McDowell" <noodles@earth.li>,
"Ken Moffat" <zarniwhoop73@googlemail.com>,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Darren Salt" <devspam@moreofthesa.me.uk>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: [PATCH v4 5/6] hwmon: (k10temp) Don't show temperature limits on Ryzen (Zen) CPUs
Date: Wed, 22 Jan 2020 08:07:59 -0800 [thread overview]
Message-ID: <20200122160800.12560-6-linux@roeck-us.net> (raw)
In-Reply-To: <20200122160800.12560-1-linux@roeck-us.net>
The maximum Tdie or Tctl is not published for Ryzen CPUs. What is
known, however, is that the traditional value of 70 degrees C is no
longer correct. On top of that, the limit applies to Tctl, not to Tdie.
Displaying it in either context is meaningless, confusing, and wrong.
Stop doing it.
Tested-by: Brad Campbell <lists2009@fnarfbargle.com>
Tested-by: Holger Kiehl <holger.kiehl@dwd.de>
Tested-by: Michael Larabel <michael@phoronix.com>
Tested-by: Jonathan McDowell <noodles@earth.li>
Tested-by: Ken Moffat <zarniwhoop73@googlemail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/k10temp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index b961e12c6f58..4a470b5195ee 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -355,7 +355,7 @@ static umode_t k10temp_is_visible(const void *_data,
}
break;
case hwmon_temp_max:
- if (channel)
+ if (channel || data->show_tdie)
return 0;
break;
case hwmon_temp_crit:
--
2.17.1
next prev parent reply other threads:[~2020-01-22 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 16:07 [PATCH v4 0/6] hwmon: k10temp driver improvements Guenter Roeck
2020-01-22 16:07 ` [PATCH v4 1/6] hwmon: (k10temp) Use bitops Guenter Roeck
2020-01-22 16:07 ` [PATCH v4 2/6] hmon: (k10temp) Convert to use devm_hwmon_device_register_with_info Guenter Roeck
2020-01-22 16:07 ` [PATCH v4 3/6] hwmon: (k10temp) Report temperatures per CPU die Guenter Roeck
2020-01-22 16:07 ` [PATCH v4 4/6] hwmon: (k10temp) Show core and SoC current and voltages on Ryzen CPUs Guenter Roeck
2020-01-22 16:07 ` Guenter Roeck [this message]
2020-01-22 16:08 ` [PATCH v4 6/6] hwmon: (k10temp) Add debugfs support Guenter Roeck
2020-01-24 0:01 ` Ken Moffat
2020-01-24 4:47 ` Guenter Roeck
2020-01-22 19:05 ` [PATCH v4 0/6] hwmon: k10temp driver improvements Sebastian Reichel
2020-01-22 19:37 ` Guenter Roeck
2020-01-25 17:40 ` Holger Kiehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122160800.12560-6-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Holger.Kiehl@dwd.de \
--cc=bernhard.gebetsberger@gmx.at \
--cc=clemens@ladisch.de \
--cc=devspam@moreofthesa.me.uk \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists2009@fnarfbargle.com \
--cc=michael@phoronix.com \
--cc=noodles@earth.li \
--cc=ocerman@sda1.eu \
--cc=sebastian.reichel@collabora.com \
--cc=zarniwhoop73@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.