All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
	Denis Plotnikov <dplotnikov@virtuozzo.com>,
	qemu-devel@nongnu.org
Cc: "Cornelia Huck" <cohuck@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: [PATCH 3/6] tests/acceptance/virtio_seg_max_adjust: List machine being tested
Date: Wed, 22 Jan 2020 23:32:44 +0100	[thread overview]
Message-ID: <20200122223247.30419-4-philmd@redhat.com> (raw)
In-Reply-To: <20200122223247.30419-1-philmd@redhat.com>

Add logging for easier debugging of failures:

  $ avocado --show=machine run tests/acceptance/virtio_seg_max_adjust.py
   (1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types:
  machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
  machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
  machine: {'name': 'pc-q35-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
  machine: {'name': 'pc-i440fx-2.5', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
  machine: {'name': 'pc-i440fx-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'}
  ...

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/virtio_seg_max_adjust.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py
index 51a2dd76e8..f679b0eec7 100755
--- a/tests/acceptance/virtio_seg_max_adjust.py
+++ b/tests/acceptance/virtio_seg_max_adjust.py
@@ -21,6 +21,7 @@
 import sys
 import os
 import re
+import logging
 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
 from qemu.machine import QEMUMachine
@@ -73,6 +74,9 @@ class VirtioMaxSegSettingsCheck(Test):
         return query_ok, props, error
 
     def check_mt(self, mt, dev_type_name):
+        mt['device'] = dev_type_name # Only for the debug() call.
+        logger = logging.getLogger('machine')
+        logger.debug(mt)
         with QEMUMachine(self.qemu_bin) as vm:
             vm.set_machine(mt["name"])
             for s in VM_DEV_PARAMS[dev_type_name]:
-- 
2.21.1



  parent reply	other threads:[~2020-01-22 22:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 22:32 [PATCH 0/6] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86 Philippe Mathieu-Daudé
2020-01-22 22:32 ` [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines Philippe Mathieu-Daudé
2020-01-23 11:20   ` Cornelia Huck
2020-01-23 13:55   ` Wainer dos Santos Moschetta
2020-01-22 22:32 ` [PATCH 2/6] tests/acceptance/virtio_seg_max_adjust: Improve exception logging Philippe Mathieu-Daudé
2020-01-22 22:32 ` Philippe Mathieu-Daudé [this message]
2020-01-22 22:32 ` [PATCH 4/6] tests/acceptance/virtio_seg_max_adjust: Only test Xen as superuser Philippe Mathieu-Daudé
2020-01-23 11:28   ` Cornelia Huck
2020-01-22 22:32 ` [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture Philippe Mathieu-Daudé
2020-01-23 11:48   ` Cornelia Huck
2020-01-23 13:36     ` Wainer dos Santos Moschetta
2020-01-23 16:00       ` Cornelia Huck
2020-01-22 22:32 ` [PATCH 6/6] tests/acceptance/virtio_seg_max_adjust: Restrict to Linux host Philippe Mathieu-Daudé
2020-01-23 11:51   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200122223247.30419-4-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=crosa@redhat.com \
    --cc=dplotnikov@virtuozzo.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.