From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBDEC33CBA for ; Thu, 23 Jan 2020 07:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DE96217F4 for ; Thu, 23 Jan 2020 07:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgAWHYi (ORCPT ); Thu, 23 Jan 2020 02:24:38 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:34668 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgAWHYi (ORCPT ); Thu, 23 Jan 2020 02:24:38 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CDE0680487; Thu, 23 Jan 2020 08:24:30 +0100 (CET) Date: Thu, 23 Jan 2020 08:24:29 +0100 From: Sam Ravnborg To: David Lechner , Geert Uytterhoeven Cc: Mark Rutland , devicetree@vger.kernel.org, Geert Uytterhoeven , David Airlie , Kieran Bingham , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , Chris Brandt , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r Message-ID: <20200123072429.GA11848@ravnborg.org> References: <20200115124548.3951-1-geert+renesas@glider.be> <20200115124548.3951-2-geert+renesas@glider.be> <20200120190249.GA9619@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120190249.GA9619@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=WZHNqt2aAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=hiXH8xowJhRCH_7nMvoA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=PrHl9onO2p7xFKlKy1af:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote: > Hi David. > > > > +allOf: > > > + - $ref: panel/panel-common.yaml# > > > > not all of these properties are applicable. > > > > > > +required: > > > + - compatible > > > + - reg > > > + - dc-gpios > > > + - reset-gpios > > > > Missing optional rotation and backlight properties. > > Thanks for catching this. I have written a little .yaml files > since I applied this - and learned a little more of the syntax. > > See attached patch for my attempt to fix this. > Please review. Hi David, Geert. Any feedback on this patch? Sam > > Sam > > >From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg > Date: Mon, 20 Jan 2020 19:55:04 +0100 > Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r > > David Lechner noticed (paraphrased): > - not all properties from panel-common are applicable. > - missing optional rotation and backlight properties > > Fix this by listing all allowed properties, and do not allow other properties. > > Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema") > Reported-by: David Lechner > Signed-off-by: Sam Ravnborg > Cc: Geert Uytterhoeven > Cc: David Lechner > Cc: Rob Herring > Cc: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > index 8892d79e6e10..0cebaaefda03 100644 > --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > @@ -39,12 +39,19 @@ properties: > maxItems: 1 > description: Display data/command selection (D/CX) > > + backlight: true > + reg: true > + reset-gpios: true > + rotation: true > + > required: > - compatible > - reg > - dc-gpios > - reset-gpios > > +additionalProperties: false > + > examples: > - | > #include > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506D8C33CAA for ; Thu, 23 Jan 2020 07:24:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D110217F4 for ; Thu, 23 Jan 2020 07:24:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D110217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B73706FB10; Thu, 23 Jan 2020 07:24:37 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id F10776FB10 for ; Thu, 23 Jan 2020 07:24:35 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CDE0680487; Thu, 23 Jan 2020 08:24:30 +0100 (CET) Date: Thu, 23 Jan 2020 08:24:29 +0100 From: Sam Ravnborg To: David Lechner , Geert Uytterhoeven Subject: Re: [PATCH] dt-bindings: restrict properties for sitronix,st7735r Message-ID: <20200123072429.GA11848@ravnborg.org> References: <20200115124548.3951-1-geert+renesas@glider.be> <20200115124548.3951-2-geert+renesas@glider.be> <20200120190249.GA9619@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200120190249.GA9619@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=WZHNqt2aAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=hiXH8xowJhRCH_7nMvoA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=PrHl9onO2p7xFKlKy1af:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Geert Uytterhoeven , David Airlie , linux-kernel@vger.kernel.org, Rob Herring , linux-renesas-soc@vger.kernel.org, Chris Brandt , Kieran Bingham , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 20, 2020 at 08:02:49PM +0100, Sam Ravnborg wrote: > Hi David. > > > > +allOf: > > > + - $ref: panel/panel-common.yaml# > > > > not all of these properties are applicable. > > > > > > +required: > > > + - compatible > > > + - reg > > > + - dc-gpios > > > + - reset-gpios > > > > Missing optional rotation and backlight properties. > > Thanks for catching this. I have written a little .yaml files > since I applied this - and learned a little more of the syntax. > > See attached patch for my attempt to fix this. > Please review. Hi David, Geert. Any feedback on this patch? Sam > > Sam > > >From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg > Date: Mon, 20 Jan 2020 19:55:04 +0100 > Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r > > David Lechner noticed (paraphrased): > - not all properties from panel-common are applicable. > - missing optional rotation and backlight properties > > Fix this by listing all allowed properties, and do not allow other properties. > > Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema") > Reported-by: David Lechner > Signed-off-by: Sam Ravnborg > Cc: Geert Uytterhoeven > Cc: David Lechner > Cc: Rob Herring > Cc: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > index 8892d79e6e10..0cebaaefda03 100644 > --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > @@ -39,12 +39,19 @@ properties: > maxItems: 1 > description: Display data/command selection (D/CX) > > + backlight: true > + reg: true > + reset-gpios: true > + rotation: true > + > required: > - compatible > - reg > - dc-gpios > - reset-gpios > > +additionalProperties: false > + > examples: > - | > #include > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel