From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D16C2D0DB for ; Thu, 23 Jan 2020 14:54:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D2F221569 for ; Thu, 23 Jan 2020 14:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cqg1ZzVa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2F221569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iudsI-0007Aj-3n for qemu-devel@archiver.kernel.org; Thu, 23 Jan 2020 09:54:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44125) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iucL0-0007IX-5A for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:15:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iucKz-00006Y-1C for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:15:58 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:52963 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iucKy-000066-TO for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:15:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579785356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+TC+nC2953LkxJR8vEt5nvvgeRLEdVxwCY4K7LgWPMA=; b=Cqg1ZzVataSrlQwEfz9yQRsFChLtaXN0j7eWtsAUk/rnFEc4v4n63TABHqboaTioDanw2C SfRN1TH2/wPRRtm3jTbFdTOQoPgizxXjv4/hg+rhkzuUh3yjiB+rFZi41rHqe180ZFYsP3 7KWDtFozoXTKXlo28tEJ0K9RTPWjJuM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-1p3WcDNWP26Aj1H2By9v2A-1; Thu, 23 Jan 2020 08:15:54 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6EE51107ACC5; Thu, 23 Jan 2020 13:15:53 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52F055DA7C; Thu, 23 Jan 2020 13:15:52 +0000 (UTC) Date: Thu, 23 Jan 2020 14:15:49 +0100 From: Andrew Jones To: Igor Mammedov Subject: Re: [PATCH REPOST v3 27/80] arm/sabrelite: use memdev for RAM Message-ID: <20200123131549.py7lx7cvl5zs42i2@kamzik.brq.redhat.com> References: <1579779525-20065-1-git-send-email-imammedo@redhat.com> <1579779525-20065-28-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 In-Reply-To: <1579779525-20065-28-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 1p3WcDNWP26Aj1H2By9v2A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, jcd@tribudubois.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 23, 2020 at 12:37:52PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and using MachineState::ram instead of manually initializing > RAM memory region. >=20 > PS: > remove no longer needed IMX6Sabrelite >=20 > Signed-off-by: Igor Mammedov > --- > CC: drjones@redhat.com > CC: peter.maydell@linaro.org > CC: qemu-arm@nongnu.org > CC: jcd@tribudubois.net > --- > hw/arm/sabrelite.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > I don't know anything about sabrelite, but I promised Igor to put another pair of eyes on his changes. Looks fine to me. Reviewed-by: Andrew Jones =20