From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C41C2D0DB for ; Thu, 23 Jan 2020 20:05:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2B5E24655 for ; Thu, 23 Jan 2020 20:05:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ga6WVETh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2B5E24655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuijh-0000An-2m for qemu-devel@archiver.kernel.org; Thu, 23 Jan 2020 15:05:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuiDk-0007Cu-Q6 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 14:32:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuiDh-0002ZO-9i for qemu-devel@nongnu.org; Thu, 23 Jan 2020 14:32:51 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60543 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuiDh-0002Z3-48 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 14:32:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579807968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+dlxji2N9Q5ypX42iV9ZJCIA1m2iOF1WwvvGqXUobtc=; b=ga6WVEThxueleSzdrx1+pVNh17ZvR9MxTuY/M//Zb/RPBAiTg7HzTnPkowysESvZhvbMkU pt4IxbZe1wdcgXQN66A8LSkm0T2H4zkbZjBY7QJflX9P8CLa6hj9ppdI2AH6ZcH55N9ccl 1tbiDGEUBk6R7IHR0kdyp37lNMHpD8s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-N1OR82wHO3q05DvZdMFnig-1; Thu, 23 Jan 2020 14:32:44 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5748C8010D7; Thu, 23 Jan 2020 19:32:43 +0000 (UTC) Received: from work-vm (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E93908644C; Thu, 23 Jan 2020 19:32:39 +0000 (UTC) Date: Thu, 23 Jan 2020 19:32:37 +0000 From: "Dr. David Alan Gilbert" To: qemu-devel@nongnu.org, stefanha@redhat.com, peter.maydell@linaro.org Subject: Re: [PULL 000/108] virtiofs queue Message-ID: <20200123193237.GD2778@work-vm> References: <20200123164630.91498-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200123164630.91498-1-dgilbert@redhat.com> User-Agent: Mutt/1.13.0 (2019-11-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: N1OR82wHO3q05DvZdMFnig-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" >=20 > The following changes since commit b7c359c748a2e3ccb97a184b9739feb2cd48de= 2f: >=20 > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-p= ull-request' into staging (2020-01-23 14:38:43 +0000) >=20 > are available in the Git repository at: >=20 > git@gitlab.com:dagrh/qemu.git tags/pull-virtiofs-20200123b Note the public URI is: https://gitlab.com/dagrh/qemu.git Dave > for you to fetch changes up to 1d59b1b210d7c3b0bdf4b10ebe0bb1fccfcb8b95: >=20 > virtiofsd: add some options to the help message (2020-01-23 16:41:37 +0= 000) >=20 > ---------------------------------------------------------------- > virtiofsd first pull v2 >=20 > Import our virtiofsd. > This pulls in the daemon to drive a file system connected to the > existing qemu virtiofsd device. > It's derived from upstream libfuse with lots of changes (and a lot > trimmed out). > The daemon lives in the newly created qemu/tools/virtiofsd >=20 > Signed-off-by: Dr. David Alan Gilbert >=20 > v2 > drop the docs while we discuss where they should live > and we need to redo the manpage in anything but texi >=20 > ---------------------------------------------------------------- > Dr. David Alan Gilbert (34): > virtiofsd: Pull in upstream headers > virtiofsd: Pull in kernel's fuse.h > virtiofsd: Add auxiliary .c's > virtiofsd: Add fuse_lowlevel.c > virtiofsd: Add passthrough_ll > virtiofsd: Trim down imported files > virtiofsd: Format imported files to qemu style > virtiofsd: Fix fuse_daemonize ignored return values > virtiofsd: Fix common header and define for QEMU builds > virtiofsd: Trim out compatibility code > virtiofsd: Add options for virtio > virtiofsd: Open vhost connection instead of mounting > virtiofsd: Start wiring up vhost-user > virtiofsd: Add main virtio loop > virtiofsd: get/set features callbacks > virtiofsd: Start queue threads > virtiofsd: Poll kick_fd for queue > virtiofsd: Start reading commands from queue > virtiofsd: Send replies to messages > virtiofsd: Keep track of replies > virtiofsd: Add Makefile wiring for virtiofsd contrib > virtiofsd: Fast path for virtio read > virtiofs: Add maintainers entry > virtiofsd: Plumb fuse_bufvec through to do_write_buf > virtiofsd: Pass write iov's all the way through > virtiofsd: cap-ng helpers > virtiofsd: Handle reinit > virtiofsd: Handle hard reboot > virtiofsd: Kill threads when queues are stopped > vhost-user: Print unexpected slave message types > contrib/libvhost-user: Protect slave fd with mutex > virtiofsd: Clean up inodes on destroy > libvhost-user: Fix some memtable remap cases > virtiofsd: Convert lo_destroy to take the lo->mutex lock itself >=20 > Eric Ren (1): > virtiofsd: fix incorrect error handling in lo_do_lookup >=20 > Eryu Guan (3): > virtiofsd: print log only when priority is high enough > virtiofsd: convert more fprintf and perror to use fuse log infra > virtiofsd: stop all queue threads on exit in virtio_loop() >=20 > Jiufei Xue (1): > virtiofsd: support nanosecond resolution for file timestamp >=20 > Liu Bo (6): > virtiofsd: fix error handling in main() > virtiofsd: cleanup allocated resource in se > virtiofsd: fix memory leak on lo.source > virtiofsd: add helper for lo_data cleanup > virtiofsd: enable PARALLEL_DIROPS during INIT > Virtiofsd: fix memory leak on fuse queueinfo >=20 > Masayoshi Mizuma (4): > virtiofsd: Add ID to the log with FUSE_LOG_DEBUG level > virtiofsd: Add timestamp to the log with FUSE_LOG_DEBUG level > virtiofsd: Prevent multiply running with same vhost_user_socket > virtiofsd: add some options to the help message >=20 > Miklos Szeredi (10): > virtiofsd: passthrough_ll: add fallback for racy ops > virtiofsd: passthrough_ll: add renameat2 support > virtiofsd: passthrough_ll: disable readdirplus on cache=3Dnever > virtiofsd: passthrough_ll: control readdirplus > virtiofsd: rename unref_inode() to unref_inode_lolocked() > virtiofsd: fail when parent inode isn't known in lo_do_lookup() > virtiofsd: extract root inode init into setup_root() > virtiofsd: passthrough_ll: clean up cache related options > virtiofsd: passthrough_ll: use hashtable > virtiofsd: passthrough_ll: fix refcounting on remove/rename >=20 > Misono Tomohiro (2): > virtiofsd: Fix data corruption with O_APPEND write in writeback mod= e > virtiofsd: passthrough_ll: Use cache_readdir for directory open >=20 > Peng Tao (1): > virtiofsd: do not always set FUSE_FLOCK_LOCKS >=20 > Stefan Hajnoczi (35): > virtiofsd: remove mountpoint dummy argument > virtiofsd: remove unused notify reply support > virtiofsd: add -o source=3DPATH to help output > virtiofsd: add --fd=3DFDNUM fd passing option > virtiofsd: make -f (foreground) the default > virtiofsd: add vhost-user.json file > virtiofsd: add --print-capabilities option > virtiofsd: passthrough_ll: add lo_map for ino/fh indirection > virtiofsd: passthrough_ll: add ino_map to hide lo_inode pointers > virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointers > virtiofsd: passthrough_ll: add fd_map to hide file descriptors > virtiofsd: validate path components > virtiofsd: add fuse_mbuf_iter API > virtiofsd: validate input buffer sizes in do_write_buf() > virtiofsd: check input buffer size in fuse_lowlevel.c ops > virtiofsd: prevent ".." escape in lo_do_lookup() > virtiofsd: prevent ".." escape in lo_do_readdir() > virtiofsd: use /proc/self/fd/ O_PATH file descriptor > virtiofsd: sandbox mount namespace > virtiofsd: move to an empty network namespace > virtiofsd: move to a new pid namespace > virtiofsd: add seccomp whitelist > virtiofsd: set maximum RLIMIT_NOFILE limit > virtiofsd: fix libfuse information leaks > virtiofsd: add --syslog command-line option > virtiofsd: use fuse_lowlevel_is_virtio() in fuse_session_destroy() > virtiofsd: prevent fv_queue_thread() vs virtio_loop() races > virtiofsd: make lo_release() atomic > virtiofsd: prevent races with lo_dirp_put() > virtiofsd: rename inode->refcount to inode->nlookup > virtiofsd: introduce inode refcount to prevent use-after-free > virtiofsd: process requests in a thread pool > virtiofsd: prevent FUSE_INIT/FUSE_DESTROY races > virtiofsd: fix lo_destroy() resource leaks > virtiofsd: add --thread-pool-size=3DNUM option >=20 > Vivek Goyal (6): > virtiofsd: Make fsync work even if only inode is passed in > virtiofsd: passthrough_ll: create new files in caller's context > virtiofsd: Parse flag FUSE_WRITE_KILL_PRIV > virtiofsd: Drop CAP_FSETID if client asked for it > virtiofsd: Support remote posix locks > virtiofsd: Reset O_DIRECT flag during file open >=20 > Xiao Yang (3): > virtiofsd: Remove unused enum fuse_buf_copy_flags > vitriofsd/passthrough_ll: fix fallocate() ifdefs > virtiofsd/passthrough_ll: Pass errno to fuse_reply_err() >=20 > piaojun (2): > virtiofsd: add definition of fuse_buf_writev() > virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better= performance >=20 > .gitignore | 1 + > MAINTAINERS | 8 + > Makefile | 12 + > Makefile.objs | 1 + > configure | 16 + > contrib/libvhost-user/libvhost-user.c | 57 +- > contrib/libvhost-user/libvhost-user.h | 6 + > docs/interop/vhost-user.json | 4 +- > hw/virtio/vhost-user.c | 2 +- > include/standard-headers/linux/fuse.h | 891 +++++++++ > scripts/update-linux-headers.sh | 1 + > tools/virtiofsd/50-qemu-virtiofsd.json.in | 5 + > tools/virtiofsd/Makefile.objs | 12 + > tools/virtiofsd/buffer.c | 351 ++++ > tools/virtiofsd/fuse.h | 1249 ++++++++++++ > tools/virtiofsd/fuse_common.h | 816 ++++++++ > tools/virtiofsd/fuse_i.h | 115 ++ > tools/virtiofsd/fuse_log.c | 41 + > tools/virtiofsd/fuse_log.h | 74 + > tools/virtiofsd/fuse_lowlevel.c | 2761 +++++++++++++++++++++++= +++ > tools/virtiofsd/fuse_lowlevel.h | 1991 +++++++++++++++++++ > tools/virtiofsd/fuse_misc.h | 60 + > tools/virtiofsd/fuse_opt.c | 450 +++++ > tools/virtiofsd/fuse_opt.h | 272 +++ > tools/virtiofsd/fuse_signals.c | 98 + > tools/virtiofsd/fuse_virtio.c | 986 ++++++++++ > tools/virtiofsd/fuse_virtio.h | 33 + > tools/virtiofsd/helper.c | 349 ++++ > tools/virtiofsd/passthrough_helpers.h | 51 + > tools/virtiofsd/passthrough_ll.c | 3006 +++++++++++++++++++++++= ++++++ > tools/virtiofsd/seccomp.c | 165 ++ > tools/virtiofsd/seccomp.h | 16 + > 32 files changed, 13886 insertions(+), 14 deletions(-) > create mode 100644 include/standard-headers/linux/fuse.h > create mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in > create mode 100644 tools/virtiofsd/Makefile.objs > create mode 100644 tools/virtiofsd/buffer.c > create mode 100644 tools/virtiofsd/fuse.h > create mode 100644 tools/virtiofsd/fuse_common.h > create mode 100644 tools/virtiofsd/fuse_i.h > create mode 100644 tools/virtiofsd/fuse_log.c > create mode 100644 tools/virtiofsd/fuse_log.h > create mode 100644 tools/virtiofsd/fuse_lowlevel.c > create mode 100644 tools/virtiofsd/fuse_lowlevel.h > create mode 100644 tools/virtiofsd/fuse_misc.h > create mode 100644 tools/virtiofsd/fuse_opt.c > create mode 100644 tools/virtiofsd/fuse_opt.h > create mode 100644 tools/virtiofsd/fuse_signals.c > create mode 100644 tools/virtiofsd/fuse_virtio.c > create mode 100644 tools/virtiofsd/fuse_virtio.h > create mode 100644 tools/virtiofsd/helper.c > create mode 100644 tools/virtiofsd/passthrough_helpers.h > create mode 100644 tools/virtiofsd/passthrough_ll.c > create mode 100644 tools/virtiofsd/seccomp.c > create mode 100644 tools/virtiofsd/seccomp.h >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK