From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8681C35240 for ; Fri, 24 Jan 2020 01:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EE3D2087E for ; Fri, 24 Jan 2020 01:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729347AbgAXBut (ORCPT ); Thu, 23 Jan 2020 20:50:49 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:56261 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728665AbgAXBut (ORCPT ); Thu, 23 Jan 2020 20:50:49 -0500 Received: from dread.disaster.area (pa49-195-162-125.pa.nsw.optusnet.com.au [49.195.162.125]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 1FA6F3A45C0; Fri, 24 Jan 2020 12:50:47 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iuo7S-0000Me-Kz; Fri, 24 Jan 2020 12:50:46 +1100 Date: Fri, 24 Jan 2020 12:50:46 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org, Christoph Hellwig Subject: Re: [PATCH 09/12] xfs: remove the xfs_btree_get_buf[ls] functions Message-ID: <20200124015046.GJ7090@dread.disaster.area> References: <157976531016.2388944.3654360225810285604.stgit@magnolia> <157976536826.2388944.18178452175492745683.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157976536826.2388944.18178452175492745683.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=eqEhQ2W7mF93FbYHClaXRw==:117 a=eqEhQ2W7mF93FbYHClaXRw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JuDxSlhT3OO6blO4plAA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jan 22, 2020 at 11:42:48PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Remove the xfs_btree_get_bufs and xfs_btree_get_bufl functions, since > they're pretty trivial oneliners. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig > --- > fs/xfs/libxfs/xfs_alloc.c | 16 +++++++++------- > fs/xfs/libxfs/xfs_bmap.c | 14 +++++++++----- > fs/xfs/libxfs/xfs_btree.c | 46 --------------------------------------------- > fs/xfs/libxfs/xfs_btree.h | 21 --------------------- > 4 files changed, 18 insertions(+), 79 deletions(-) Nice simplification! Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com