From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51524C35242 for ; Fri, 24 Jan 2020 05:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2243720838 for ; Fri, 24 Jan 2020 05:34:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="NxNxPOFz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730322AbgAXFef (ORCPT ); Fri, 24 Jan 2020 00:34:35 -0500 Received: from sonic304-23.consmr.mail.gq1.yahoo.com ([98.137.68.204]:43176 "EHLO sonic304-23.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730348AbgAXFee (ORCPT ); Fri, 24 Jan 2020 00:34:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1579844073; bh=UeJz9jyBNt5yayp7xj4f/SZWo0DpuycvuaFMYq1D8lg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=NxNxPOFzSfORh0/j+CyjrCAXbIzvw6ZHJA0VT8plACOZ69yKZ55in66tkPbpWIcBeXRauEXemw1f9NZuEngyqU03g5dB2t0fRuOpKrpSqk8C7OW5sREI1tfvGJjw4vYKZ/lvWk3ek5sXuqAZt4K5kdJmwHm0MomdHvKzEawtNAehxb0CgxWxvNx+s99RX0sZNdPqqqSbCC6Aev27kzSxU6jkruWXIi0S0gL0xTj9CIwK1UdChRNGYcPS8deeuVlDZVq1SKvJ9xi1Y65+dhmbGqLOBiFGfdn31thYTepR1qhDojoNp+AVSFypKdEH2/fJUEGPrlDs7rirncqaTnWvYg== X-YMail-OSG: jpBgorYVM1niDtoaJJkIHlAQwijPN.6fSmZoI4.D5pZpqmPkPgbrgdCc3bajoGE 9NFLvAJZlQp9e_slnmrybNZnRd7.xfJeiO6p85yik1XdVrNwNPhSm7jC9gCYQpbQ1MkUkVhqXlP8 CbEPhu4VEYevwxrsg6VN3Rpigk9xLiQ0ucRw.WZKNCtGQ_AkCTxq_fYq_ss8sbV.95yBQIXJ0RSE zRDQNhHjjg.aO7x1BBPbsgppivpLGEgOiP7lO9Z.lhCBjTtlCBAVap3b1O1SDS1bjkBV8phceVDM nFcv_4kWg4jLu8D.dxw_dzp_fyrhpnFP.AFhMPhf_hhugMfXrsiPdNzfoREF07wZDwdbuPOML59U Oo7RuXpvNk6UbxfDveVZFmJHvf1oaNZGMjrZcOaGq0E6mUW45Op3kBteRJ.Syn1W.FigWSPEMjbl OmdiDgOaJ2ExqCMAvX9L_99nm25IX76gES9xIONRNAu.vzQsrhtppRKnGUS9YiZ3IvX6CndPC2.F 0wvZIz9aW8HHlg7FUPmiplPN91NmJrJ6aPO1noqJQSTV23HC38nDaMllXTr_GkK7TGnc94flHjou zwP0NLw8Sw_ajvTHDXIOSE4nKr08X0bJ8rqqwOl_HgHcte4Zoi1ZJqvUSiKA1UYOW27wzv8lcyrK e1WNg9KWHpUZHamY4taOgz8.8XNJ2F_i5RH4PapB4xFfr8cw9bAySh9Bkpy4VROqymI7I7JPY00q Iyy7E.wWJfM8ch.37t2vFxAqcqqm1PMlcXfeBQl9TFfNLq6cAKRZWsr8oNGp4HlJHApqOaFm1.Q4 8RNzJwUqJ87Crb3sx0unDxhoHpV6AiXotap4dvQmv_f7aLd0GrG5hUccDlTdPCEklvQeP9nIEZqv OPy6RwATC6wnGkKQseChbiXzfsybZbyNpXc6tfzCjki99l23c44E9ukJdbDmWKNQ95ga73oghi.I 97wQS8b3Vz9_x5Eh6yqw55CUvejzxvwFeM8DH4cskesjYGhgQQb2Vjr.AiPZeOu5d8umJZjTZG3g mcuTqSUCqRUF5C62h4Khc9AWYp57Mr59cTTFXwlCrSyYJFEp9l90dhncXdL4S.26.0SQ0vJvKhBZ X3BpqbjCVSdFOhNyzOnCp2_BrmCagUDAUATKCuedlydlI68tUQ_OkkkIHvOqoXSAO7meALGjHMsP OMISiC2VQSlwwKmGIDOFLJsDqTl6SLV1vDZ2r1nALsat6ul2TGkpmvM_q9AGMorgiS3LRghQWAvI z4EhmII8xNvwUT8cxPFrX06Yhfll.WNp7qiY6pMIb_ZkuZLaHhKochdff.I9l8U6QToEgzG0AEKD X1nwNxGlfh5jUxtNLWD267If67nf456b57TzIDkE1KOIbHMfgw4SLofRbwDWkPsZglTDkBaBnCWr 1advyz4RlnpkNGQ9QV.pBaXmwhD6r72hh8fiCGsLBbA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Fri, 24 Jan 2020 05:34:33 +0000 Received: by smtp432.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5154e0a93daa76c8f17f548eb900f9b7; Fri, 24 Jan 2020 05:34:30 +0000 (UTC) Date: Fri, 24 Jan 2020 13:34:23 +0800 From: Gao Xiang To: Eric Biggers Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Alexander Viro , Daniel Rosenberg , Gabriel Krisman Bertazi Subject: Re: [PATCH] ext4: fix race conditions in ->d_compare() and ->d_hash() Message-ID: <20200124053415.GC31271@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20200124041234.159740-1-ebiggers@kernel.org> <20200124050423.GA31271@hsiangkao-HP-ZHAN-66-Pro-G1> <20200124051601.GB832@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200124051601.GB832@sol.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailer: WebService/1.1.14873 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 23, 2020 at 09:16:01PM -0800, Eric Biggers wrote: [] > So we need READ_ONCE() to ensure that a consistent value is used. By the way, my understanding is all pointer could be accessed atomicly guaranteed by compiler. In my opinion, we generally use READ_ONCE() on pointers for other uses (such as, avoid accessing a variable twice due to compiler optimization and it will break some logic potentially or need some data dependency barrier...) Thanks, Gao Xiang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9E7C2D0CE for ; Fri, 24 Jan 2020 05:44:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE1782077C; Fri, 24 Jan 2020 05:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="Cgwq3dCq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Z00dQG2X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="MRRkZFp+"; dkim=neutral (0-bit key) header.d=aol.com header.i=@aol.com header.b="deaF3/93" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE1782077C Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kXOQJ43uZqpaUqqyIxBM3PO9YtzqIkTXk6rX1FKxot8=; b=Cgwq3dCqqiKPUDp2IBfOfM4hs Fnz5PQ4Veg2UvHyunRSQePDlfpsrDWATY8pQQU7qgvGUPfsCk9aq2SfJV9DJfFqbXUs8HomWnUIGz 2YDoGGz9MpIj4O3ZhSuIfjKIK+t1X/BLL4zdG9i/nCUCj2nZ5rMzUfqYkxczMkEoZPOiI=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iurlv-0001sT-F2; Fri, 24 Jan 2020 05:44:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iurlu-0001sA-Jc for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Jan 2020 05:44:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UeJz9jyBNt5yayp7xj4f/SZWo0DpuycvuaFMYq1D8lg=; b=Z00dQG2X+PDUTTCGRUlWpVSL9i yHq0t702Iana/N0fw1QJu8/WKqtu5Zx7i7RSmOUvO1He/5Jbe7/zAGzdgMQJI+EvMxCFKlkCLbJ1n MBrSdLHpmfOiYsvo3yCHCz+QPIeERD1B35Ron3r5I6xytI2+Swf6XJUtdeGUdJe0yFME=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UeJz9jyBNt5yayp7xj4f/SZWo0DpuycvuaFMYq1D8lg=; b=MRRkZFp+//7abK1su4zeQ1x8j2 5s6Npzf1CO/xeTpUnP6p3kgUOs02VV+TADI9DSszFl3t5sdh0oJB2/dwCY102EGUdoHHwnUsHsFjl islodknXJtjpxuaYjq5u2xsJLxVuF+D0xoYFNFbRtlYmIrusOp4L4rg5Enh64wkR8cE8=; Received: from sonic314-21.consmr.mail.gq1.yahoo.com ([98.137.69.84]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1iurlt-003JDu-8u for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Jan 2020 05:44:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1579844679; bh=UeJz9jyBNt5yayp7xj4f/SZWo0DpuycvuaFMYq1D8lg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=deaF3/93Y86x1r+EQkWAbbINH7I4pLd3qAY6MwodWVrGGyFhBCsFK0ryzBKhpRNb2Y2vNiyeUSSVSsa+d8J0KHL7uj5nQsrxG3yOeZWbzDmhK6YDjP3yNGlhcYIEiBx6+am9UdJccLY0WdzJUh3NG1c3SAdKgFoaf6REz3GokpOR0NV9pkY6ghA/N2EZj+Ldjk4MtaZV2QohtpC7ELjw0wddIIHoU181S9H6lWgHKNkrhBwpJBZ5+5wv9oBGrBpF0oTTQF7kms5oxA0JASSZ34hVbKwm7ZSk3Lmbq1GXtlGv+7UK5tyuzi1U56TlQPh+uuGnjFF+WB004cM6/3TX4Q== X-YMail-OSG: jpBgorYVM1niDtoaJJkIHlAQwijPN.6fSmZoI4.D5pZpqmPkPgbrgdCc3bajoGE 9NFLvAJZlQp9e_slnmrybNZnRd7.xfJeiO6p85yik1XdVrNwNPhSm7jC9gCYQpbQ1MkUkVhqXlP8 CbEPhu4VEYevwxrsg6VN3Rpigk9xLiQ0ucRw.WZKNCtGQ_AkCTxq_fYq_ss8sbV.95yBQIXJ0RSE zRDQNhHjjg.aO7x1BBPbsgppivpLGEgOiP7lO9Z.lhCBjTtlCBAVap3b1O1SDS1bjkBV8phceVDM nFcv_4kWg4jLu8D.dxw_dzp_fyrhpnFP.AFhMPhf_hhugMfXrsiPdNzfoREF07wZDwdbuPOML59U Oo7RuXpvNk6UbxfDveVZFmJHvf1oaNZGMjrZcOaGq0E6mUW45Op3kBteRJ.Syn1W.FigWSPEMjbl OmdiDgOaJ2ExqCMAvX9L_99nm25IX76gES9xIONRNAu.vzQsrhtppRKnGUS9YiZ3IvX6CndPC2.F 0wvZIz9aW8HHlg7FUPmiplPN91NmJrJ6aPO1noqJQSTV23HC38nDaMllXTr_GkK7TGnc94flHjou zwP0NLw8Sw_ajvTHDXIOSE4nKr08X0bJ8rqqwOl_HgHcte4Zoi1ZJqvUSiKA1UYOW27wzv8lcyrK e1WNg9KWHpUZHamY4taOgz8.8XNJ2F_i5RH4PapB4xFfr8cw9bAySh9Bkpy4VROqymI7I7JPY00q Iyy7E.wWJfM8ch.37t2vFxAqcqqm1PMlcXfeBQl9TFfNLq6cAKRZWsr8oNGp4HlJHApqOaFm1.Q4 8RNzJwUqJ87Crb3sx0unDxhoHpV6AiXotap4dvQmv_f7aLd0GrG5hUccDlTdPCEklvQeP9nIEZqv OPy6RwATC6wnGkKQseChbiXzfsybZbyNpXc6tfzCjki99l23c44E9ukJdbDmWKNQ95ga73oghi.I 97wQS8b3Vz9_x5Eh6yqw55CUvejzxvwFeM8DH4cskesjYGhgQQb2Vjr.AiPZeOu5d8umJZjTZG3g mcuTqSUCqRUF5C62h4Khc9AWYp57Mr59cTTFXwlCrSyYJFEp9l90dhncXdL4S.26.0SQ0vJvKhBZ X3BpqbjCVSdFOhNyzOnCp2_BrmCagUDAUATKCuedlydlI68tUQ_OkkkIHvOqoXSAO7meALGjHMsP OMISiC2VQSlwwKmGIDOFLJsDqTl6SLV1vDZ2r1nALsat6ul2TGkpmvM_q9AGMorgiS3LRghQWAvI z4EhmII8xNvwUT8cxPFrX06Yhfll.WNp7qiY6pMIb_ZkuZLaHhKochdff.I9l8U6QToEgzG0AEKD X1nwNxGlfh5jUxtNLWD267If67nf456b57TzIDkE1KOIbHMfgw4SLofRbwDWkPsZglTDkBaBnCWr 1advyz4RlnpkNGQ9QV.pBaXmwhD6r72hh8fiCGsLBbA-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Fri, 24 Jan 2020 05:44:39 +0000 Received: by smtp432.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5154e0a93daa76c8f17f548eb900f9b7; Fri, 24 Jan 2020 05:34:30 +0000 (UTC) Date: Fri, 24 Jan 2020 13:34:23 +0800 To: Eric Biggers Message-ID: <20200124053415.GC31271@hsiangkao-HP-ZHAN-66-Pro-G1> References: <20200124041234.159740-1-ebiggers@kernel.org> <20200124050423.GA31271@hsiangkao-HP-ZHAN-66-Pro-G1> <20200124051601.GB832@sol.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200124051601.GB832@sol.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailer: WebService/1.1.14873 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-Headers-End: 1iurlt-003JDu-8u Subject: Re: [f2fs-dev] [PATCH] ext4: fix race conditions in ->d_compare() and ->d_hash() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Gao Xiang via Linux-f2fs-devel Reply-To: Gao Xiang Cc: Daniel Rosenberg , linux-f2fs-devel@lists.sourceforge.net, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jan 23, 2020 at 09:16:01PM -0800, Eric Biggers wrote: [] > So we need READ_ONCE() to ensure that a consistent value is used. By the way, my understanding is all pointer could be accessed atomicly guaranteed by compiler. In my opinion, we generally use READ_ONCE() on pointers for other uses (such as, avoid accessing a variable twice due to compiler optimization and it will break some logic potentially or need some data dependency barrier...) Thanks, Gao Xiang _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel