From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D155C2D0DB for ; Fri, 24 Jan 2020 11:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2876620708 for ; Fri, 24 Jan 2020 11:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864242; bh=n7t4sp4v2CHzDCSSFze4RGRUhIvQyibZc4fAQt0orW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jN7wRjKBb+HJ5Hcve0Og0qO06vtTfLRawlQC8rpeCELFtmoXVetbv9G2hyvsAxzTO wZIN4YvU1/1jku+X/H9hrIx5gxCZqadv0sYoIVD7SjJe7H8Ufg6N2YsaMDJQvrImhh z7HS5T489CNv0B0lIjQSWrgfQsVmV3lKZoR0t6xw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733087AbgAXLKl (ORCPT ); Fri, 24 Jan 2020 06:10:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:46426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732697AbgAXLKh (ORCPT ); Fri, 24 Jan 2020 06:10:37 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11DC92071A; Fri, 24 Jan 2020 11:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864236; bh=n7t4sp4v2CHzDCSSFze4RGRUhIvQyibZc4fAQt0orW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P7Bn96zbi1ROk0LKe0CbKbxbtfXPJnf04YHR0SSxJIoKzbtxe2Rd8EY3DeKPpRqYr reCVK30fdYqMFRmuuITSPeMnQCI/VUyFq9TlCfrTsc5d0ZO9pyQ39sfq5BjoVqcI7j GxOtBcDEidBIxjM/G8sU/2q1Bs1Djdgeo7oUeNvQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lindgren , Bin Liu , Sven Van Asbroeck , Felipe Balbi , Sasha Levin Subject: [PATCH 4.19 197/639] usb: phy: twl6030-usb: fix possible use-after-free on remove Date: Fri, 24 Jan 2020 10:26:07 +0100 Message-Id: <20200124093111.730620744@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Van Asbroeck [ Upstream commit 5895d311d28f2605e2f71c1a3e043ed38f3ac9d2 ] In remove(), use cancel_delayed_work_sync() to cancel the delayed work. Otherwise there's a chance that this work will continue to run until after the device has been removed. This issue was detected with the help of Coccinelle. Cc: Tony Lindgren Cc: Bin Liu Fixes: b6a619a883c3 ("usb: phy: Check initial state for twl6030") Signed-off-by: Sven Van Asbroeck Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/phy/phy-twl6030-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c index 183550b63faad..dade34d704198 100644 --- a/drivers/usb/phy/phy-twl6030-usb.c +++ b/drivers/usb/phy/phy-twl6030-usb.c @@ -400,7 +400,7 @@ static int twl6030_usb_remove(struct platform_device *pdev) { struct twl6030_usb *twl = platform_get_drvdata(pdev); - cancel_delayed_work(&twl->get_status_work); + cancel_delayed_work_sync(&twl->get_status_work); twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK, REG_INT_MSK_LINE_C); twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK, -- 2.20.1