From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB62C2D0DB for ; Fri, 24 Jan 2020 11:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E89502087E for ; Fri, 24 Jan 2020 11:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864826; bh=cx/nSVJngerfZa7sPy/5nVYQe9qvWBVZeqT8wg5K0Bo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=f2INgcRNBlh4lKNDQw2ip5DisuJ9KO34LI75kSHJjIAw/mFsp7bLFZg9RsvUoCTFz a6upH8Ik7YUJ+UMG0LXXY+6C8JC3dhb8+fHUx7oH8mlL1V+xnH6SQs5t4nHblXay7x aheAnc2/TTUG38twX+HC7lDQcPBiVlzJ53lHhAKc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390920AbgAXLUZ (ORCPT ); Fri, 24 Jan 2020 06:20:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:58020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390894AbgAXLUX (ORCPT ); Fri, 24 Jan 2020 06:20:23 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26C382087E; Fri, 24 Jan 2020 11:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579864822; bh=cx/nSVJngerfZa7sPy/5nVYQe9qvWBVZeqT8wg5K0Bo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qwi8EFvSjYp69cSyNub9k8rpAwUso/8yHbQUKqajQ7lNW0HyKXhu7jn2gCKGBe9HQ WEVVU/veuw+aQ/BmIjIiO77Qj7/7LQ4tlisxz9bNawXHSvTXxuRa0uRlysh0E8q5/8 GFblVVlUgCLOPRuUcwAntQyNQOdWW8IGn/wlVI5g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mario Limonciello , Andy Shevchenko , Sasha Levin Subject: [PATCH 4.19 362/639] platform/x86: alienware-wmi: printing the wrong error code Date: Fri, 24 Jan 2020 10:28:52 +0100 Message-Id: <20200124093132.457859705@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ] The "out_data" variable is uninitialized at the point. Originally, this used to print "status" instead and that seems like the correct thing to print. Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status") Signed-off-by: Dan Carpenter Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/alienware-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index c0d1555735cdd..83fd7677af24c 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev, return scnprintf(buf, PAGE_SIZE, "input [gpu] unknown\n"); } - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data); + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status); return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n"); } -- 2.20.1