From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8C2C2D0DB for ; Fri, 24 Jan 2020 11:55:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79374206F0 for ; Fri, 24 Jan 2020 11:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DJB3I2zT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79374206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuxYx-0006NL-Nf for qemu-devel@archiver.kernel.org; Fri, 24 Jan 2020 06:55:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38268) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuxYC-0005wP-VA for qemu-devel@nongnu.org; Fri, 24 Jan 2020 06:55:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuxYB-00032g-KL for qemu-devel@nongnu.org; Fri, 24 Jan 2020 06:55:00 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:21680 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuxYB-00031r-GV for qemu-devel@nongnu.org; Fri, 24 Jan 2020 06:54:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579866898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ul60ukctsHHsV520q/CF+ZTCMBxdmeElAGr7YvGQ0Q0=; b=DJB3I2zT1lNWd4rHnLSRXmVE2T9iFPcwd/JXX3aOLGNO6eBoJQpN4PIFRuPxfuUGufruBQ 4nnFxFE6X3vJtI18DhZ2gaUG1F8z4GkoASaLbFVuRE/iaz2p43P7slFAJBoTwScGshan+t i2AeWVrYvBuICkD5o8a93QZ4feHM3Mg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-Ra-VlVG4NAW1VQ1G5xvSZw-1; Fri, 24 Jan 2020 06:54:55 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DC871005510 for ; Fri, 24 Jan 2020 11:54:54 +0000 (UTC) Received: from work-vm (ovpn-117-253.ams2.redhat.com [10.36.117.253]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACD9060BE1; Fri, 24 Jan 2020 11:54:52 +0000 (UTC) Date: Fri, 24 Jan 2020 11:54:50 +0000 From: "Dr. David Alan Gilbert" To: Juan Quintela Subject: Re: [PATCH v3 15/21] migration: Make checkpatch happy with comments Message-ID: <20200124115450.GM2970@work-vm> References: <20200123115831.36842-1-quintela@redhat.com> <20200123115831.36842-16-quintela@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200123115831.36842-16-quintela@redhat.com> User-Agent: Mutt/1.13.0 (2019-11-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: Ra-VlVG4NAW1VQ1G5xvSZw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/migration/ram.c b/migration/ram.c > index 14b7cbdbc9..c24b4cc771 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1312,10 +1312,12 @@ static void multifd_recv_terminate_threads(Error = *err) > =20 > qemu_mutex_lock(&p->mutex); > p->quit =3D true; > - /* We could arrive here for two reasons: > - - normal quit, i.e. everything went fine, just finished > - - error quit: We close the channels so the channel threads > - finish the qio_channel_read_all_eof() */ > + /* > + * We could arrive here for two reasons: > + * - normal quit, i.e. everything went fine, just finished > + * - error quit: We close the channels so the channel threads > + * finish the qio_channel_read_all_eof() > + */ > if (p->c) { > qio_channel_shutdown(p->c, QIO_CHANNEL_SHUTDOWN_BOTH, NULL); > } > --=20 > 2.24.1 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK