All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	David Lechner <david@lechnology.com>
Subject: Re: [PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver()
Date: Fri, 24 Jan 2020 18:06:37 +0100	[thread overview]
Message-ID: <20200124170637.GA7264@ravnborg.org> (raw)
In-Reply-To: <20200122105403.30035-2-andriy.shevchenko@linux.intel.com>

Hi Andy.

On Wed, Jan 22, 2020 at 12:54:01PM +0200, Andy Shevchenko wrote:
> The spi_register_driver() will set the ->owner member to THIS_MODULE.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

Any chance you will update the remaining 3 drivers in drm/tiny/
that has the same unessesary assignment?

	Sam

> ---
>  drivers/gpu/drm/tiny/repaper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c
> index fd9e95ce3201..4a497203923f 100644
> --- a/drivers/gpu/drm/tiny/repaper.c
> +++ b/drivers/gpu/drm/tiny/repaper.c
> @@ -1198,7 +1198,6 @@ static void repaper_shutdown(struct spi_device *spi)
>  static struct spi_driver repaper_spi_driver = {
>  	.driver = {
>  		.name = "repaper",
> -		.owner = THIS_MODULE,
>  		.of_match_table = repaper_of_match,
>  	},
>  	.id_table = repaper_id,
> -- 
> 2.24.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-01-24 17:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 10:54 [PATCH v1 1/4] drm/tiny/repaper: Make driver OF-independent Andy Shevchenko
2020-01-22 10:54 ` [PATCH v1 2/4] drm/tiny/repaper: No need to set ->owner for spi_register_driver() Andy Shevchenko
2020-01-22 16:02   ` David Lechner
2020-01-24 17:06   ` Sam Ravnborg [this message]
2020-01-24 17:32     ` Andy Shevchenko
2020-01-22 10:54 ` [PATCH v1 3/4] drm/tiny/st7735r: Make driver OF-independent Andy Shevchenko
2020-01-22 16:01   ` David Lechner
2020-01-22 10:54 ` [PATCH v1 4/4] drm/tiny/st7735r: No need to set ->owner for spi_register_driver() Andy Shevchenko
2020-01-22 16:00   ` David Lechner
2020-01-27  9:03     ` Daniel Vetter
2020-01-24 16:42 ` [PATCH v1 1/4] drm/tiny/repaper: Make driver OF-independent Sam Ravnborg
2020-01-24 17:31   ` Andy Shevchenko
2020-01-24 18:18     ` Sam Ravnborg
2020-01-27  9:39       ` Andy Shevchenko
2020-01-29 20:29         ` Sam Ravnborg
2020-01-31 19:45           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124170637.GA7264@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david@lechnology.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.