From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A05C2D0DB for ; Fri, 24 Jan 2020 17:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DD712077C for ; Fri, 24 Jan 2020 17:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579886890; bh=xKeYSTzuiPLpfoVHzYLcCkTA5xYucgBlImpWHbcWV68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jiyXwQNhIWK9jj0wGhCmYnmnSZBX3O5YpP1u+Vqbu383+wugpqRqychtLpZQ5R6yL FHD/pm0EsfelnJ3vXS2ofDA+oaHIDNIdOzNKGOB/FZDUq4FFpSx4bfsGW3LQkNbJFe MwvHjTsbkkvnFl6Cwx2RHFrE6HhNCHWcQ5sU1l6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390650AbgAXR2J (ORCPT ); Fri, 24 Jan 2020 12:28:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:48536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387661AbgAXR2I (ORCPT ); Fri, 24 Jan 2020 12:28:08 -0500 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48D6A2081E; Fri, 24 Jan 2020 17:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579886887; bh=xKeYSTzuiPLpfoVHzYLcCkTA5xYucgBlImpWHbcWV68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zRe2habaFvk9T+b2yK7elYh+xguEe1nojGQ77ceriPknPrR2alzAVIxo6UFvRXJj5 AasbxKpQdE+Eu0RhYNa7kSIeP1dWDdspxGl2v8TW+7sSbvPmH/NbK8/N7pkyu/lzhN hXL+RPzQUA6+/vxRHTFJSOG8TF70g9NzgXkaVcN4= Date: Sat, 25 Jan 2020 02:28:03 +0900 From: Keith Busch To: Amol Grover Cc: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Joel Fernandes , Madhuparna Bhowmik , "Paul E . McKenney" , kbuild test robot Subject: Re: [PATCH v3] drivers: nvme: target: core: Pass lockdep expression to RCU lists Message-ID: <20200124172803.GA18688@redsun51.ssa.fujisawa.hgst.com> References: <20200111073815.7659-1-frextrite@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200111073815.7659-1-frextrite@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 11, 2020 at 01:08:16PM +0530, Amol Grover wrote: > ctrl->subsys->namespaces and subsys->namespaces are traversed with > list_for_each_entry_rcu outside an RCU read-side critical section > but under the protection of ctrl->subsys->lock and subsys->lock > respectively. > > Hence, add the corresponding lockdep expression to the list traversal > primitive to silence false-positive lockdep warnings, and > harden RCU lists. > > Reported-by: kbuild test robot > Reviewed-by: Joel Fernandes (Google) > Signed-off-by: Amol Grover Thanks, added for-5.6. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00EBC2D0DB for ; Fri, 24 Jan 2020 17:28:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3C8C2071A for ; Fri, 24 Jan 2020 17:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FhDrhdBz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zRe2haba" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3C8C2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3mSvPit/qWbOQ3kH6ML3xM1NLvgJTLwe5xdfHskXkZw=; b=FhDrhdBz+/TOGt oLdJbx1MhXBADj7JsZVbhNlExES9AwvFR6wCn83R0aLEe8aYlk5e6YzqmBUPiHc7CUF/8LldE37ty CQBnxsVd0gG+V0OPCgZMdlnT5Rj0kGtVyU257vYe0y9u6dpULCbv5kxEr+/rmABu/ODKFiuenyaOp tnXh23/FS0H22TKnCA5dddk+zldQQjTS9AeXCAhPNK6Qv32+WZu839h3U8WTzHE67mmOkChW40OVV hUE1khL8Kde/6PS8EbxIQdzmJKQPUSPuAlRse6Cyen520ZMeTIeMIwiPfvq+jfW6ElwnmwPIM6ahF O0DmoavIUNJV6AREW4ZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iv2kf-0000sJ-Oe; Fri, 24 Jan 2020 17:28:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iv2kd-0000qV-4P for linux-nvme@lists.infradead.org; Fri, 24 Jan 2020 17:28:12 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48D6A2081E; Fri, 24 Jan 2020 17:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579886887; bh=xKeYSTzuiPLpfoVHzYLcCkTA5xYucgBlImpWHbcWV68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zRe2habaFvk9T+b2yK7elYh+xguEe1nojGQ77ceriPknPrR2alzAVIxo6UFvRXJj5 AasbxKpQdE+Eu0RhYNa7kSIeP1dWDdspxGl2v8TW+7sSbvPmH/NbK8/N7pkyu/lzhN hXL+RPzQUA6+/vxRHTFJSOG8TF70g9NzgXkaVcN4= Date: Sat, 25 Jan 2020 02:28:03 +0900 From: Keith Busch To: Amol Grover Subject: Re: [PATCH v3] drivers: nvme: target: core: Pass lockdep expression to RCU lists Message-ID: <20200124172803.GA18688@redsun51.ssa.fujisawa.hgst.com> References: <20200111073815.7659-1-frextrite@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200111073815.7659-1-frextrite@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200124_092811_193446_60C30CAB X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Chaitanya Kulkarni , "Paul E . McKenney" , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org, Christoph Hellwig , Madhuparna Bhowmik , kbuild test robot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sat, Jan 11, 2020 at 01:08:16PM +0530, Amol Grover wrote: > ctrl->subsys->namespaces and subsys->namespaces are traversed with > list_for_each_entry_rcu outside an RCU read-side critical section > but under the protection of ctrl->subsys->lock and subsys->lock > respectively. > > Hence, add the corresponding lockdep expression to the list traversal > primitive to silence false-positive lockdep warnings, and > harden RCU lists. > > Reported-by: kbuild test robot > Reviewed-by: Joel Fernandes (Google) > Signed-off-by: Amol Grover Thanks, added for-5.6. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8855CC3F68F for ; Fri, 24 Jan 2020 17:28:10 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D59C2075D for ; Fri, 24 Jan 2020 17:28:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zRe2haba" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D59C2075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 276B922775; Fri, 24 Jan 2020 17:28:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ul7yGcb2K-di; Fri, 24 Jan 2020 17:28:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 978CB203E1; Fri, 24 Jan 2020 17:28:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 844DBC1D80; Fri, 24 Jan 2020 17:28:09 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 512A8C0174 for ; Fri, 24 Jan 2020 17:28:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3763722775 for ; Fri, 24 Jan 2020 17:28:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8SJ2ThIpXDj7 for ; Fri, 24 Jan 2020 17:28:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id C5BBC203E1 for ; Fri, 24 Jan 2020 17:28:07 +0000 (UTC) Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48D6A2081E; Fri, 24 Jan 2020 17:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579886887; bh=xKeYSTzuiPLpfoVHzYLcCkTA5xYucgBlImpWHbcWV68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zRe2habaFvk9T+b2yK7elYh+xguEe1nojGQ77ceriPknPrR2alzAVIxo6UFvRXJj5 AasbxKpQdE+Eu0RhYNa7kSIeP1dWDdspxGl2v8TW+7sSbvPmH/NbK8/N7pkyu/lzhN hXL+RPzQUA6+/vxRHTFJSOG8TF70g9NzgXkaVcN4= Date: Sat, 25 Jan 2020 02:28:03 +0900 From: Keith Busch To: Amol Grover Message-ID: <20200124172803.GA18688@redsun51.ssa.fujisawa.hgst.com> References: <20200111073815.7659-1-frextrite@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200111073815.7659-1-frextrite@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: Sagi Grimberg , Chaitanya Kulkarni , "Paul E . McKenney" , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org, Christoph Hellwig , kbuild test robot Subject: Re: [Linux-kernel-mentees] [PATCH v3] drivers: nvme: target: core: Pass lockdep expression to RCU lists X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Sat, Jan 11, 2020 at 01:08:16PM +0530, Amol Grover wrote: > ctrl->subsys->namespaces and subsys->namespaces are traversed with > list_for_each_entry_rcu outside an RCU read-side critical section > but under the protection of ctrl->subsys->lock and subsys->lock > respectively. > > Hence, add the corresponding lockdep expression to the list traversal > primitive to silence false-positive lockdep warnings, and > harden RCU lists. > > Reported-by: kbuild test robot > Reviewed-by: Joel Fernandes (Google) > Signed-off-by: Amol Grover Thanks, added for-5.6. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees