From: Matthew Wilcox <willy@infradead.org>
To: Chen Yu <yu.c.chen@intel.com>
Cc: linux-pci@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH][RFC] PCI: Add "pci=blacklist_dev=" parameter to blacklist specific devices
Date: Fri, 24 Jan 2020 11:27:43 -0800 [thread overview]
Message-ID: <20200124192743.GL4675@bombadil.infradead.org> (raw)
In-Reply-To: <20200124144248.11719-1-yu.c.chen@intel.com>
On Fri, Jan 24, 2020 at 10:42:48PM +0800, Chen Yu wrote:
> It was found that on some platforms the bogus pci device might bring
> troubles to the system. For example, on a MacBookPro the system could
> not be power off or suspended due to internal pci resource confliction
> between bogus pci device and [io 0x1804]. Another case is that, once
> resumed from hibernation on a VM, the pci config space of a pci device
> is corrupt.
>
> To narrow down and benefit future debugging for such kind of issues,
> introduce the command line blacklist_dev=<vendor:device_id>> to blacklist
> such pci devices thus they will not be scanned thus not visible after
> bootup. For example,
>
> pci.blacklist_dev=8086:293e
>
> forbid the audio device to be exposed to the OS.
This feels really unsafe to me. Just because Linux ignores the device
doesn't mean the device will ignore I/O requests. I think we should
call this pci.disable_dev and clear the device's I/O Space Enable,
Memory Space Enable and Bus Master Enable bits (in the Command register,
config space offset 4).
next prev parent reply other threads:[~2020-01-24 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 14:42 [PATCH][RFC] PCI: Add "pci=blacklist_dev=" parameter to blacklist specific devices Chen Yu
2020-01-24 19:27 ` Matthew Wilcox [this message]
2020-01-28 2:09 ` Chen Yu
2020-01-24 19:31 ` Bjorn Helgaas
2020-01-29 1:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124192743.GL4675@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=lenb@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.