From: Al Viro <viro@zeniv.linux.org.uk>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/adfs: bigdir: Fix an error code in adfs_fplus_read()
Date: Sat, 25 Jan 2020 16:32:51 +0000 [thread overview]
Message-ID: <20200125163251.GL23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200125092930.GQ25745@shell.armlinux.org.uk>
On Sat, Jan 25, 2020 at 09:29:30AM +0000, Russell King - ARM Linux admin wrote:
> On Fri, Jan 24, 2020 at 01:15:37PM +0300, Dan Carpenter wrote:
> > This code accidentally returns success, but it should return the
> > -EIO error code from adfs_fplus_validate_header().
> >
> > Fixes: d79288b4f61b ("fs/adfs: bigdir: calculate and validate directory checkbyte")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Good catch.
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Al, please apply, thanks.
Applied and pushed out.
next prev parent reply other threads:[~2020-01-25 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 10:15 [PATCH] fs/adfs: bigdir: Fix an error code in adfs_fplus_read() Dan Carpenter
2020-01-24 10:15 ` Dan Carpenter
2020-01-25 9:29 ` Russell King - ARM Linux admin
2020-01-25 16:32 ` Al Viro [this message]
2021-05-19 10:18 Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125163251.GL23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=info@metux.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.