From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: akolli@codeaurora.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe
Date: Sun, 26 Jan 2020 10:23:44 +0000 (UTC) [thread overview]
Message-ID: <20200126102344.BED86C433A2@smtp.codeaurora.org> (raw)
In-Reply-To: <20191219131539.1003793-2-bryan.odonoghue@linaro.org>
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> ath10k_pci_dump_memory_reg() will try to access memory of type
> ATH10K_MEM_REGION_TYPE_IOREG however, if a hardware restart is in progress
> this can crash a system.
>
> Individual ioread32() time has been observed to jump from 15-20 ticks to >
> 80k ticks followed by a secure-watchdog bite and a system reset.
>
> Work around this corner case by only issuing the read transaction when the
> driver state is ATH10K_STATE_ON.
>
> Tested-on: QCA9988 PCI 10.4-3.9.0.2-00044
>
> Fixes: 219cc084c6706 ("ath10k: add memory dump support QCA9984")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2 patches applied to ath-next branch of ath.git, thanks.
d239380196c4 ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe
63ec5cbc31f7 ath10k: pci: Fix comment on ath10k_pci_dump_memory_sram
--
https://patchwork.kernel.org/patch/11303563/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-01-26 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:15 [PATCH 0/2] ath10k: pci: Two PCI related fixups Bryan O'Donoghue
2019-12-19 13:15 ` Bryan O'Donoghue
2019-12-19 13:15 ` [PATCH 1/2] ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe Bryan O'Donoghue
2019-12-19 13:15 ` Bryan O'Donoghue
2019-12-19 13:53 ` Kalle Valo
2019-12-19 13:53 ` Kalle Valo
2019-12-19 14:15 ` Bryan O'Donoghue
2019-12-19 14:15 ` Bryan O'Donoghue
2019-12-19 14:21 ` Kalle Valo
2019-12-19 14:21 ` Kalle Valo
2019-12-19 14:29 ` Bryan O'Donoghue
2019-12-19 14:29 ` Bryan O'Donoghue
2020-01-26 10:23 ` Kalle Valo [this message]
2020-01-26 10:23 ` Kalle Valo
2019-12-19 13:15 ` [PATCH 2/2] ath10k: pci: Fix comment on ath10k_pci_dump_memory_sram Bryan O'Donoghue
2019-12-19 13:15 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126102344.BED86C433A2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.