All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 07/21] dm: core: Update comment for ofnode_get_chosen_node()
Date: Mon, 27 Jan 2020 08:49:42 -0700	[thread overview]
Message-ID: <20200127084920.7.If25281d45a0cd34637ee21792c9926a836078fcc@changeid> (raw)
In-Reply-To: <20200127154956.64368-1-sjg@chromium.org>

The current comment is a big vague and misleading. Rewrite it to state
precisely what the function does.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/dm/ofnode.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h
index 4282169706..62ba0c13ea 100644
--- a/include/dm/ofnode.h
+++ b/include/dm/ofnode.h
@@ -520,11 +520,14 @@ ofnode ofnode_path(const char *path);
 const char *ofnode_get_chosen_prop(const char *propname);
 
 /**
- * ofnode_get_chosen_node() - get the chosen node
+ * ofnode_get_chosen_node() - get a referenced node from the chosen node
  *
- * @return the chosen node if present, else ofnode_null()
+ * This looks up a named property in the chosen node and uses that as a path to
+ * look up a code.
+ *
+ * @return the referenced node if present, else ofnode_null()
  */
-ofnode ofnode_get_chosen_node(const char *name);
+ofnode ofnode_get_chosen_node(const char *propname);
 
 struct display_timing;
 /**
-- 
2.25.0.341.g760bfbb309-goog

  parent reply	other threads:[~2020-01-27 15:49 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 15:49 [PATCH 00/21] dm: Various enhancements to prepare for ACPI Simon Glass
2020-01-27 15:49 ` [PATCH 01/21] dm: core: Use const where possible in device.h Simon Glass
2020-01-27 15:49 ` [PATCH 02/21] dm: pci: Update the PCI read_config() method to const dev * Simon Glass
2020-02-03  1:42   ` Tan, Ley Foon
2020-02-05 17:57   ` sjg at google.com
2020-01-27 15:49 ` [PATCH 03/21] dm: pci: Update a few more interfaces for const udevice * Simon Glass
2020-01-27 15:49 ` [PATCH 04/21] dm: core: Use const device for the devfdt...() interface Simon Glass
2020-01-27 15:49 ` [PATCH 05/21] dm: core: Use const device for the dev_read_...() interface Simon Glass
2020-01-27 15:49 ` [PATCH 06/21] test: Add underscore prefix to macro parameters Simon Glass
2020-01-27 15:49 ` Simon Glass [this message]
2020-01-27 15:49 ` [PATCH 08/21] dm: core: Rename ofnode_get_chosen_prop() Simon Glass
2020-01-27 15:49 ` [PATCH 09/21] dm: core: Add ofnode_read_prop() Simon Glass
2020-01-27 15:49 ` [PATCH 10/21] dm: core: Reimplement ofnode_read_size() Simon Glass
2020-01-27 15:49 ` [PATCH 11/21] dm: core: Add ofnode_get_chosen_prop() Simon Glass
2020-01-27 15:49 ` [PATCH 12/21] dm: core: Add a way to read platdata for all child devices Simon Glass
2020-01-27 15:49 ` [PATCH 13/21] dm: core: Add a way to iterate through children, probing each Simon Glass
2020-01-27 15:49 ` [PATCH 14/21] dm: core: Drop uclass_find_next_free_req_seq() conditions Simon Glass
2020-01-27 15:49 ` [PATCH 15/21] bloblist: Add a new function to add or check size Simon Glass
2020-01-27 15:49 ` [PATCH 16/21] bloblist: Tidy up a few comments and code-style nits Simon Glass
2020-01-27 15:49 ` [PATCH 17/21] bloblist: Zero records when adding Simon Glass
2020-01-27 15:49 ` [PATCH 18/21] sandbox: pmic: Correct i2c pmic emulator platdata method Simon Glass
2020-01-27 15:49 ` [PATCH 19/21] console: Add a function to read a line of the output / eof Simon Glass
2020-01-27 15:49 ` [PATCH 20/21] test: Enable console recording in tests Simon Glass
2020-01-27 15:49 ` [PATCH 21/21] test: Add a way to check each line of console output Simon Glass
2020-02-05 17:55 ` sjg at google.com
2020-02-05 17:55 ` [PATCH 20/21] test: Enable console recording in tests sjg at google.com
2020-02-05 17:55 ` [PATCH 19/21] console: Add a function to read a line of the output / eof sjg at google.com
2020-02-12 17:14   ` Heinrich Schuchardt
2020-02-12 17:24     ` Tom Rini
2020-02-12 22:14       ` Tom Rini
2020-02-05 17:55 ` [PATCH 18/21] sandbox: pmic: Correct i2c pmic emulator platdata method sjg at google.com
2020-02-05 17:55 ` [PATCH 17/21] bloblist: Zero records when adding sjg at google.com
2020-02-05 17:55 ` [PATCH 16/21] bloblist: Tidy up a few comments and code-style nits sjg at google.com
2020-02-05 17:55 ` [PATCH 15/21] bloblist: Add a new function to add or check size sjg at google.com
2020-02-05 17:55 ` [PATCH 14/21] dm: core: Drop uclass_find_next_free_req_seq() conditions sjg at google.com
2020-02-05 17:56 ` [PATCH 12/21] dm: core: Add a way to read platdata for all child devices sjg at google.com
2020-02-05 17:56 ` [PATCH 13/21] dm: core: Add a way to iterate through children, probing each sjg at google.com
2020-02-05 17:56 ` [PATCH 11/21] dm: core: Add ofnode_get_chosen_prop() sjg at google.com
2020-02-05 17:56 ` [PATCH 10/21] dm: core: Reimplement ofnode_read_size() sjg at google.com
2020-02-05 17:56 ` [PATCH 09/21] dm: core: Add ofnode_read_prop() sjg at google.com
2020-02-05 17:56 ` [PATCH 08/21] dm: core: Rename ofnode_get_chosen_prop() sjg at google.com
2020-02-05 17:56 ` [PATCH 07/21] dm: core: Update comment for ofnode_get_chosen_node() sjg at google.com
2020-02-05 17:56 ` [PATCH 06/21] test: Add underscore prefix to macro parameters sjg at google.com
2020-02-05 17:56 ` [PATCH 05/21] dm: core: Use const device for the dev_read_...() interface sjg at google.com
2020-02-05 17:56 ` [PATCH 04/21] dm: core: Use const device for the devfdt...() interface sjg at google.com
2020-02-05 17:57 ` [PATCH 03/21] dm: pci: Update a few more interfaces for const udevice * sjg at google.com
2020-02-05 17:57 ` [PATCH 01/21] dm: core: Use const where possible in device.h sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127084920.7.If25281d45a0cd34637ee21792c9926a836078fcc@changeid \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.