From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F13C32771 for ; Mon, 27 Jan 2020 09:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE4A921569 for ; Mon, 27 Jan 2020 09:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580117281; bh=Y6b7dIlDJuPnFX3aDH9nm/OaNreSy+VArBY8hxqT7bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wbjT4vzcCkiwfYPLZYCiVkjAph35o6ec+k0qEvMQ7BbS8L/nrE5kJBGy9nLpERz0P ql+HgW4Q9KMOOOu6MgUot8FFudFi5By9/ryhmGH9bnWBFLA64ARgVqojc91nc+ZkQV HXc8wwWHHSYH6QtYqy9P6/zSZ+zxVYeNzKw04N/U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbgA0J2B (ORCPT ); Mon, 27 Jan 2020 04:28:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:41936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgA0J2B (ORCPT ); Mon, 27 Jan 2020 04:28:01 -0500 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B89E12071E; Mon, 27 Jan 2020 09:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580117280; bh=Y6b7dIlDJuPnFX3aDH9nm/OaNreSy+VArBY8hxqT7bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TmXC2cieqs95HncR9Ajyzcva2Q+dqOrIQN6mpYcDzGdQhmyR6nr8gMyZi0mgSKmyI k1PIzkLQqyQrFlMUScxhptErKGxV+8Qn2QxMuobHXGLGRnXYVY29PQdFad9J+n/mI3 ajZdFBa6300fl5F8CnWe9M55nRJ9TxedsYLY7nvs= Date: Mon, 27 Jan 2020 11:27:57 +0200 From: Leon Romanovsky To: Devesh Sharma Cc: Jason Gunthorpe , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" Subject: Re: [PATCH for-next 1/7] RDMA/bnxt_re: Refactor queue pair creation code Message-ID: <20200127092757.GN3870@unreal> References: <1579845165-18002-1-git-send-email-devesh.sharma@broadcom.com> <1579845165-18002-2-git-send-email-devesh.sharma@broadcom.com> <20200125174645.GC4616@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jan 27, 2020 at 01:46:13PM +0530, Devesh Sharma wrote: > On Mon, Jan 27, 2020 at 1:43 PM Devesh Sharma > wrote: > > > > On Sat, Jan 25, 2020 at 11:16 PM Jason Gunthorpe wrote: > > > > > > On Fri, Jan 24, 2020 at 12:52:39AM -0500, Devesh Sharma wrote: > > > > +static int bnxt_re_destroy_gsi_sqp(struct bnxt_re_qp *qp) > > > > +{ > > > > + struct bnxt_re_qp *gsi_sqp; > > > > + struct bnxt_re_ah *gsi_sah; > > > > + struct bnxt_re_dev *rdev; > > > > + int rc = 0; > > > > + > > > > + rdev = qp->rdev; > > > > + gsi_sqp = rdev->gsi_ctx.gsi_sqp; > > > > + gsi_sah = rdev->gsi_ctx.gsi_sah; > > > > + > > > > + /* remove from active qp list */ > > > > + mutex_lock(&rdev->qp_lock); > > > > + list_del(&gsi_sqp->list); > > > > + atomic_dec(&rdev->qp_count); > > > > + mutex_unlock(&rdev->qp_lock); > > > > + > > > > + dev_dbg(rdev_to_dev(rdev), "Destroy the shadow AH\n"); > > > > + bnxt_qplib_destroy_ah(&rdev->qplib_res, > > > > + &gsi_sah->qplib_ah, > > > > + true); > > > > + bnxt_qplib_clean_qp(&qp->qplib_qp); > > > > + > > > > + dev_dbg(rdev_to_dev(rdev), "Destroy the shadow QP\n"); > > > > + rc = bnxt_qplib_destroy_qp(&rdev->qplib_res, &gsi_sqp->qplib_qp); > > > > + if (rc) { > > > > + dev_err(rdev_to_dev(rdev), "Destroy Shadow QP failed"); > > > > + goto fail; > > > > + } > > > > + bnxt_qplib_free_qp_res(&rdev->qplib_res, &gsi_sqp->qplib_qp); > > > > + > > > > + kfree(rdev->gsi_ctx.sqp_tbl); > > > > + kfree(gsi_sah); > > > > + kfree(gsi_sqp); > > > > + rdev->gsi_ctx.gsi_sqp = NULL; > > > > + rdev->gsi_ctx.gsi_sah = NULL; > > > > + rdev->gsi_ctx.sqp_tbl = NULL; > > > > + > > > > + return 0; > > > > +fail: > > > > + mutex_lock(&rdev->qp_lock); > > > > + list_add_tail(&gsi_sqp->list, &rdev->qp_list); > > > > + atomic_inc(&rdev->qp_count); > > > > + mutex_unlock(&rdev->qp_lock); > > > > + return rc; > > > > > > This error unwind approach looks racy. destroy is not allowed to > > > fail, so why all this mess? > > True, the unwind is not required, even if the driver wants to keep it > > for debugging purpose, the zombie resource would give rise to > > confusion. > > > > > > > /* Queue Pairs */ > > > > int bnxt_re_destroy_qp(struct ib_qp *ib_qp, struct ib_udata *udata) > > > > { > > > > @@ -750,10 +797,18 @@ int bnxt_re_destroy_qp(struct ib_qp *ib_qp, struct ib_udata *udata) > > > > unsigned int flags; > > > > int rc; > > > > > > > > + mutex_lock(&rdev->qp_lock); > > > > + list_del(&qp->list); > > > > + atomic_dec(&rdev->qp_count); > > > > + mutex_unlock(&rdev->qp_lock); > > > > bnxt_qplib_flush_cqn_wq(&qp->qplib_qp); > > > > rc = bnxt_qplib_destroy_qp(&rdev->qplib_res, &qp->qplib_qp); > > > > if (rc) { > > > > dev_err(rdev_to_dev(rdev), "Failed to destroy HW QP"); > > > > + mutex_lock(&rdev->qp_lock); > > > > + list_add_tail(&qp->list, &rdev->qp_list); > > > > + atomic_inc(&rdev->qp_count); > > > > + mutex_unlock(&rdev->qp_lock); > > > > return rc; > > > > } > > > > > > More.. > > Let me see if I can remove it in this series, else future series would > > remove it. > > > > > > Jason > > At the top level, if provider driver is so keen on returning success > in any case, should we change the return type to void of > ib_destroy_xx() hooks? We are doing it but in extremely slow way. Patches are welcomed. Thanks