From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD61C35246 for ; Tue, 28 Jan 2020 08:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D25E324681 for ; Tue, 28 Jan 2020 08:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580199326; bh=ds5dM3AIAtcb+wm25J2UVNjJPJLyE/L9V/4RrPyIPr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MbIzrSmAxQFtyRrgakXaP4tQAvesJhubb3Des+40egD/+G8syHpzxxg3wLWrXwuI8 k47UnqdzDs5WIQENpzxS6P9Aj4JRH19OdMYAPlO5v9CJNcnJ1k/BZ/8pHT5SrG4NlZ J4tDvqCJJJT9P0WjQD9pd7Emr0LjjNxGEQW5ThhM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725920AbgA1IP0 (ORCPT ); Tue, 28 Jan 2020 03:15:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:34914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgA1IPZ (ORCPT ); Tue, 28 Jan 2020 03:15:25 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C17F2467B; Tue, 28 Jan 2020 08:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580199324; bh=ds5dM3AIAtcb+wm25J2UVNjJPJLyE/L9V/4RrPyIPr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PM0n0JNfC02/ZfV8nuuf67Ms78ascFZ+WMQ2LKb//+/97/4TikoCyrQyrW9Rwum99 agE1xWJ5j0yke0UVRfsGHZHF6cqfs0teMaIg+MOsWTYt0xqjW4ddj+E32jHZKNGO/U jXnLwO4iz2ET5qHawKynoZsChqX39LSj11BhnSUc= Date: Tue, 28 Jan 2020 09:15:20 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Cc: Sasha Levin , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200128081520.GL2105706@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> <20200115172126.GB4127163@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 05:28:19PM +0000, Suzuki Kuruppassery Poulose wrote: > On 15/01/2020 17:21, Greg KH wrote: > > On Wed, Jan 15, 2020 at 04:44:29PM +0000, Suzuki Kuruppassery Poulose wrote: > > > > > > Hi Greg, > > > > > > On 15/01/2020 15:11, Greg KH wrote: > > > > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > > > > > On 09/01/2020 14:35, Sasha Levin wrote: > > > > > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > > > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > > > > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > > > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > > > > > use the current CPU node, using smp_processor_id(). However this is > > > > > > > unsafe > > > > > > > in a pre-emptible context and could generate the splats as below : > > > > > > > > > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > > > > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > > > > > not bound to CPUs. > > > > > > > > > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > > > > > Cc: Mathieu Poirier > > > > > > > Signed-off-by: Suzuki K Poulose > > > > > > > Cc: stable # v4.9 to v4.19 > > > > > > > Signed-off-by: Mathieu Poirier > > > > > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > > > > > > > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > > > > > also had to be resolved. > > > > > > > > > > > > > > > > > > > > > Thanks Sasha ! > > > > > > > > Note, these had to all be dropped as they broke the build :( > > > > > > > > So can you please send us patches that at least build? :) > > > > > > > > > > Do you have a build failure log ? I did build test it before sending it > > > over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build > > > failures here. > > > > > > Please could you share the log if you have it handy ? > > > > It was in the stable -rc review emails, I don't have it handy, sorry. > > > > I think there is a bit of confusion here. If you're referring to > > https://lkml.org/lkml/2020/1/11/634 > > as the build failure report, this is precisely my series fixes. > I sent this series to address the build break reported by Nathan. > The original patches were picked up from the "Fixes" tag automatically > which broke the build due to missing "event" parameter. This series > fixes those build issues and for sure builds fine for the affected > versions. Trust me ;-) Ok, for some reason it looked like the "original" commits were added to the tree, not your backports. I've queued up your backports now, that should solve the issue. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C14C35240 for ; Tue, 28 Jan 2020 08:15:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E96D62467B for ; Tue, 28 Jan 2020 08:15:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hGmA5WhC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PM0n0JNf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E96D62467B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rMOgX6b/ggO3r9/JDwlc8ot2KNeHGxistHfFRUQBrD4=; b=hGmA5WhCrM/uqb o9eIvNxTolTxDzJp21l+nIrCIrgF3JG/kIRASybs+xUiAjjW6d3RhlTC4d2dgz4tYA6RVbpjJ+pln cvx73L3fYIjZHvWDg3xM7DYTQUchkAcmy9Rawn/kOO9IjwzyC5Bqd31xvEShuwwN7SILYR/SSPiiN NVaNDJ6RNZLVuvAG8NCSMnScEpbc//R4x0GHTJBDyo+hD5X43orlN1RjMyOByl79/deXmYdGUU3Mc 60K0mSPtwwAszNik77E4Y7Ksguam6UvUhIPv+N4gXAzpwAfHcz1hovHJH7PEzOC07LTGi0trVeii4 uxXWfOHKvUZiCfjj85sg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwM1v-0008T1-Gr; Tue, 28 Jan 2020 08:15:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwM1s-0008SN-SQ for linux-arm-kernel@lists.infradead.org; Tue, 28 Jan 2020 08:15:26 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C17F2467B; Tue, 28 Jan 2020 08:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580199324; bh=ds5dM3AIAtcb+wm25J2UVNjJPJLyE/L9V/4RrPyIPr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PM0n0JNfC02/ZfV8nuuf67Ms78ascFZ+WMQ2LKb//+/97/4TikoCyrQyrW9Rwum99 agE1xWJ5j0yke0UVRfsGHZHF6cqfs0teMaIg+MOsWTYt0xqjW4ddj+E32jHZKNGO/U jXnLwO4iz2ET5qHawKynoZsChqX39LSj11BhnSUc= Date: Tue, 28 Jan 2020 09:15:20 +0100 From: Greg KH To: Suzuki Kuruppassery Poulose Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200128081520.GL2105706@kroah.com> References: <20200108110541.318672-1-suzuki.poulose@arm.com> <20200109143537.GE1706@sasha-vm> <20200115151118.GC3740793@kroah.com> <20200115172126.GB4127163@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200128_001524_960911_7897E59E X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2020 at 05:28:19PM +0000, Suzuki Kuruppassery Poulose wrote: > On 15/01/2020 17:21, Greg KH wrote: > > On Wed, Jan 15, 2020 at 04:44:29PM +0000, Suzuki Kuruppassery Poulose wrote: > > > > > > Hi Greg, > > > > > > On 15/01/2020 15:11, Greg KH wrote: > > > > On Thu, Jan 09, 2020 at 02:36:17PM +0000, Suzuki Kuruppassery Poulose wrote: > > > > > On 09/01/2020 14:35, Sasha Levin wrote: > > > > > > On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: > > > > > > > [ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > > > > > > > > > > > > > > During a perf session we try to allocate buffers on the "node" associated > > > > > > > with the CPU the event is bound to. If it is not bound to a CPU, we > > > > > > > use the current CPU node, using smp_processor_id(). However this is > > > > > > > unsafe > > > > > > > in a pre-emptible context and could generate the splats as below : > > > > > > > > > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > > > > > > > > > > > > > > Use NUMA_NO_NODE hint instead of using the current node for events > > > > > > > not bound to CPUs. > > > > > > > > > > > > > > Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") > > > > > > > Cc: Mathieu Poirier > > > > > > > Signed-off-by: Suzuki K Poulose > > > > > > > Cc: stable # v4.9 to v4.19 > > > > > > > Signed-off-by: Mathieu Poirier > > > > > > > Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org > > > > > > > > > > > > > > > > > > > I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which > > > > > > also had to be resolved. > > > > > > > > > > > > > > > > > > > > > Thanks Sasha ! > > > > > > > > Note, these had to all be dropped as they broke the build :( > > > > > > > > So can you please send us patches that at least build? :) > > > > > > > > > > Do you have a build failure log ? I did build test it before sending it > > > over. I tried it again on 4.9, 4.14 and 4.19. I don't hit any build > > > failures here. > > > > > > Please could you share the log if you have it handy ? > > > > It was in the stable -rc review emails, I don't have it handy, sorry. > > > > I think there is a bit of confusion here. If you're referring to > > https://lkml.org/lkml/2020/1/11/634 > > as the build failure report, this is precisely my series fixes. > I sent this series to address the build break reported by Nathan. > The original patches were picked up from the "Fixes" tag automatically > which broke the build due to missing "event" parameter. This series > fixes those build issues and for sure builds fine for the affected > versions. Trust me ;-) Ok, for some reason it looked like the "original" commits were added to the tree, not your backports. I've queued up your backports now, that should solve the issue. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel