From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDBEFC3F68F for ; Tue, 28 Jan 2020 08:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A51942465B for ; Tue, 28 Jan 2020 08:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726010AbgA1Iu6 (ORCPT ); Tue, 28 Jan 2020 03:50:58 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:13567 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbgA1Iu5 (ORCPT ); Tue, 28 Jan 2020 03:50:57 -0500 X-Originating-IP: 90.65.102.129 Received: from localhost (lfbn-lyo-1-1670-129.w90-65.abo.wanadoo.fr [90.65.102.129]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 01A9624000D; Tue, 28 Jan 2020 08:50:54 +0000 (UTC) Date: Tue, 28 Jan 2020 09:50:54 +0100 From: Alexandre Belloni To: Geert Uytterhoeven Cc: Alessandro Zummo , Akinobu Mita , Joe Perches , linux-rtc@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed Message-ID: <20200128085054.GA3398@piout.net> References: <20200112171349.22268-1-geert@linux-m68k.org> <20200127224549.GC3273@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28/01/2020 09:33:28+0100, Geert Uytterhoeven wrote: > Hi Alexandre, > > On Mon, Jan 27, 2020 at 11:45 PM Alexandre Belloni > wrote: > > On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote: > > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when > > > no driver needs it. While the former can be moduler, the latter cannot, > > > and thus becomes built-in. > > > > > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI > > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on > > > it. > > > > > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI > > > for more information, but the latter does not select REGMAP_{I2C,SPI} > > > itself, and defers that to the individual drivers, too. > > > > > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234") > > > Signed-off-by: Geert Uytterhoeven > > > --- > > > Joe: When merging addresses, scripts/get_maintainer.pl replaces > > > Alexandre's authoritative email address from MAINTAINERS by the > > > obsolete address in the SoB-line of the commit referred to by the > > > Fixes-line. > > > > > > drivers/rtc/Kconfig | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > Applied, thanks. > > According to the reports from kbuild test report, some drivers are still > missing some selects, which is exposed by this patch. > But perhaps you have already fixed those in your tree? > I did fix a bunch of those in https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=578c2b661e2b1b474ea3571a3c3c6d57bae89e8d kbuild reported that it successfully built a few configuration with that patch applied so I'm hoping it is enough. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com