All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: [igt-dev] [PATCH i-g-t 2/3] tests/kms_fbcon_fbt: User interactive debug helper
Date: Tue, 28 Jan 2020 12:25:48 +0100	[thread overview]
Message-ID: <20200128112549.172135-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20200128112549.172135-1-daniel.vetter@ffwll.ch>

Instead of hand-rolling our own which can only be enabled by recompiling.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_fbcon_fbt.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 506848cfcf47..236e09ea1ebd 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -37,8 +37,6 @@ IGT_TEST_DESCRIPTION("Test the relationship between fbcon and the frontbuffer "
 
 #define MAX_CONNECTORS 32
 
-static bool do_wait_user = false;
-
 struct drm_info {
 	int fd;
 	int debugfs_fd;
@@ -48,12 +46,8 @@ struct drm_info {
 
 static void wait_user(const char *msg)
 {
-	if (!do_wait_user)
-		return;
-
-	igt_info("%s Press enter...\n", msg);
-	while (getchar() != '\n')
-		;
+	igt_info("%s\n", msg);
+	igt_debug_wait_for_keypress("fbt");
 }
 
 static void setup_drm(struct drm_info *drm)
-- 
2.24.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-01-28 11:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 11:25 [igt-dev] [PATCH i-g-t 1/3] tests/kms_fbcon_fbt: Check for psr before keeling over Daniel Vetter
2020-01-28 11:25 ` Daniel Vetter [this message]
2020-02-07 14:21   ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_fbcon_fbt: User interactive debug helper Ville Syrjälä
2020-01-28 11:25 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_fbcon_fbt: Drop master before restoring fbcon Daniel Vetter
2020-02-07 14:19   ` Ville Syrjälä
2020-02-07 15:29     ` Daniel Vetter
2020-02-07 15:36       ` Ville Syrjälä
2020-02-10  8:04         ` Daniel Vetter
2020-01-28 15:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_fbcon_fbt: Check for psr before keeling over Patchwork
2020-01-29 20:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-02-07 14:24 ` [igt-dev] [PATCH i-g-t 1/3] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128112549.172135-2-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.