From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Date: Tue, 28 Jan 2020 12:13:15 +0000 Message-ID: <20200128121315.GD4689@sirena.org.uk> References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GpGaEY17fSl8rd50" Return-path: Content-Disposition: inline In-Reply-To: <1b3c2af4-510e-306c-749a-efffc994b20a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Jon Hunter , Ben Dooks , linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Liam Girdwood , Takashi Iwai , Thierry Reding , Edward Cragg , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --GpGaEY17fSl8rd50 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote: > 24.01.2020 19:50, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > .rates =3D SNDRV_PCM_RATE_8000_96000, > > .formats =3D SNDRV_PCM_FMTBIT_S32_LE | > > - SNDRV_PCM_FMTBIT_S24_LE | > > + SNDRV_PCM_FMTBIT_S24_3LE | > It should solve the problem in my particular case, but I'm not sure that > the solution is correct. If the format implemented by the driver is S24_3LE the driver should advertise S24_3LE. > The v5.5 kernel is released now with the broken audio and apparently > getting 24bit to work won't be trivial (if possible at all). Ben, could > you please send a patch to fix v5.5 by removing the S24 support > advertisement from the driver? Why is that the best fix rather than just advertising the format implemented by the driver? I really don't understand why this is all taking so long, this thread just seems to be going round in interminable circles long after it looked like the issue was understood. I have to admit I've not read every single message in the thread but it's difficult to see why it doesn't seem to be making any progress. --GpGaEY17fSl8rd50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4wJVoACgkQJNaLcl1U h9DMkAf/bHJV00niDhM1x/+jpTGcn0N2F9TKUa1eQk5NFuzmH+wPdJN/fVIXQ9/H 9svsreaVKTU1il6uhl3HOUB2Prenx04OggzHfRaMQ4zbB1yCd67uL83R5jlj3yao bdFTP/7O7ngzG9P7foNPQtJrWR72KEr7e6Ay4ekDrHJLiI9p0TBnwrLcA5Wop35m C/k5YwvlJ8SzZgADBN74cxrzx/E59pw9w0M31RGRhAtXTWVu7GfjiitfvKLhcJWz JfzVil637Tm3taQ4hiyqYvTGeQlUOS86ix1AcDBGQigMC0tCZtCnblr8pOhW09nv i/k+B9psW4N99h6sq5+2z85Qk/svwQ== =dv7A -----END PGP SIGNATURE----- --GpGaEY17fSl8rd50-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E72C2D0DB for ; Tue, 28 Jan 2020 12:14:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F15924687 for ; Tue, 28 Jan 2020 12:14:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DQxawIV1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F15924687 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A73BE1658; Tue, 28 Jan 2020 13:13:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A73BE1658 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580213654; bh=EP/Aa1FIkoKzRd4AZmFlovfyBcnhPSqHrB3hxyGKDmE=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DQxawIV1DbrhA7BZjDlYhhPO3QZSsycGBQioGFVD5S6EYJ5/NVXyZ3fjqaT5ouM5u zUCfcoZUjgg5srGMoNFy+bUAee3mNVM6PwS73zutVqK0S0cXBz+g4XaAfQuueyXuHU iW5Ti6F5BgX30QF6cAE3IVbXEIcx5tr136Gz5+So= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 23427F8014B; Tue, 28 Jan 2020 13:13:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C4F3F80150; Tue, 28 Jan 2020 13:13:22 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id CA633F800FF for ; Tue, 28 Jan 2020 13:13:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CA633F800FF Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FE191045; Tue, 28 Jan 2020 04:13:17 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E6EB3F52E; Tue, 28 Jan 2020 04:13:16 -0800 (PST) Date: Tue, 28 Jan 2020 12:13:15 +0000 From: Mark Brown To: Dmitry Osipenko Message-ID: <20200128121315.GD4689@sirena.org.uk> References: <29db3df4-6f51-7c0f-1eef-90171f1d233a@codethink.co.uk> <9a5447e2-155c-7e6e-b8f1-95523c6f42c6@gmail.com> <680e2dfd-6f4f-5c96-63b7-97520961dc82@gmail.com> <0e0cd260e39ad293edb881da1c565510@codethink.co.uk> <507dcd5a-672b-61ac-aa7f-af5ff01accff@codethink.co.uk> <28cafc56-095b-68c6-638d-270608a2983f@codethink.co.uk> <3d8544be-af20-f382-85fd-32183365267b@nvidia.com> <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> MIME-Version: 1.0 In-Reply-To: <1b3c2af4-510e-306c-749a-efffc994b20a@gmail.com> X-Cookie: Doing gets it done. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Ben Dooks , Thierry Reding , Edward Cragg , linux-tegra@vger.kernel.org, Jon Hunter Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8493561911761055211==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============8493561911761055211== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GpGaEY17fSl8rd50" Content-Disposition: inline --GpGaEY17fSl8rd50 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote: > 24.01.2020 19:50, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > .rates =3D SNDRV_PCM_RATE_8000_96000, > > .formats =3D SNDRV_PCM_FMTBIT_S32_LE | > > - SNDRV_PCM_FMTBIT_S24_LE | > > + SNDRV_PCM_FMTBIT_S24_3LE | > It should solve the problem in my particular case, but I'm not sure that > the solution is correct. If the format implemented by the driver is S24_3LE the driver should advertise S24_3LE. > The v5.5 kernel is released now with the broken audio and apparently > getting 24bit to work won't be trivial (if possible at all). Ben, could > you please send a patch to fix v5.5 by removing the S24 support > advertisement from the driver? Why is that the best fix rather than just advertising the format implemented by the driver? I really don't understand why this is all taking so long, this thread just seems to be going round in interminable circles long after it looked like the issue was understood. I have to admit I've not read every single message in the thread but it's difficult to see why it doesn't seem to be making any progress. --GpGaEY17fSl8rd50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4wJVoACgkQJNaLcl1U h9DMkAf/bHJV00niDhM1x/+jpTGcn0N2F9TKUa1eQk5NFuzmH+wPdJN/fVIXQ9/H 9svsreaVKTU1il6uhl3HOUB2Prenx04OggzHfRaMQ4zbB1yCd67uL83R5jlj3yao bdFTP/7O7ngzG9P7foNPQtJrWR72KEr7e6Ay4ekDrHJLiI9p0TBnwrLcA5Wop35m C/k5YwvlJ8SzZgADBN74cxrzx/E59pw9w0M31RGRhAtXTWVu7GfjiitfvKLhcJWz JfzVil637Tm3taQ4hiyqYvTGeQlUOS86ix1AcDBGQigMC0tCZtCnblr8pOhW09nv i/k+B9psW4N99h6sq5+2z85Qk/svwQ== =dv7A -----END PGP SIGNATURE----- --GpGaEY17fSl8rd50-- --===============8493561911761055211== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============8493561911761055211==--