From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21FCC33CB3 for ; Tue, 28 Jan 2020 14:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0CCE24681 for ; Tue, 28 Jan 2020 14:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220525; bh=oxyX7iDAjhVFW8oZvMoe4IB+htpefy1+hrLQ9bmVxro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bq5nP/ZGF/JOmaoVSNGOBZF8/jv1A0ODy1AgCFqMDhtJP/vsFGjZLZVq16RYC40F+ 2PnUVpEa4lpk3UobmxhacbrbpHTHFrnQrFKrHzhS2OJXjL7gZ5sFNl6jUqSh3qaWUC 0zonceh77hh6nGB8j1ZS/x0wmlbzM8wEMroOhQso= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbgA1OIl (ORCPT ); Tue, 28 Jan 2020 09:08:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:56696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726820AbgA1OIe (ORCPT ); Tue, 28 Jan 2020 09:08:34 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5D5B2468E; Tue, 28 Jan 2020 14:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220514; bh=oxyX7iDAjhVFW8oZvMoe4IB+htpefy1+hrLQ9bmVxro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C3z0W8e2kEm3jbGi5Yo6sv8Rl6cZ0i7ydtFeHV7TcW4H09KoXgxoMmdqv7KxArpMd k8Mqr0pEE7OYxrJOebMbk1rSTphi2u8wEqB9W4DQSc+6NEpwYR+Qg/I4/E8kUnMwt9 244igZdU+Xe4xxLAAMXWP+3JOMEAuYNALiWne18k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Al Viro , Sasha Levin Subject: [PATCH 4.4 009/183] exportfs: fix passing zero to ERR_PTR() warning Date: Tue, 28 Jan 2020 15:03:48 +0100 Message-Id: <20200128135830.570126507@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 909e22e05353a783c526829427e9a8de122fba9c ] Fix a static code checker warning: fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR' The error path for lookup_one_len_unlocked failure should set err to PTR_ERR. Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function") Signed-off-by: YueHaibing Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/exportfs/expfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c index 6599c6124552f..01cbdd0987c07 100644 --- a/fs/exportfs/expfs.c +++ b/fs/exportfs/expfs.c @@ -148,6 +148,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt, mutex_unlock(&parent->d_inode->i_mutex); if (IS_ERR(tmp)) { dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp)); + err = PTR_ERR(tmp); goto out_err; } if (tmp != dentry) { -- 2.20.1