From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E852AC33CB3 for ; Tue, 28 Jan 2020 14:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 794C520716 for ; Tue, 28 Jan 2020 14:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222687; bh=hGE2T1G6lPIGWI7NEOMKzgp80gd/lwiRHwpdPFENheY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ml2hEBM4pSCVYzNQ9xK9ZmVQPswAWNsoY4c294zc2SzGWRAB2fGe0hIhuvhlANjdH knP2sJ+mqawyhh55tKfKI825fJ/hi5V1gmv+kF8lC3BoTB8t0BfSeRF8ft6fPzcdpq xFW9yPgeyT04DEq8QKiRRB2nGQiHZdrTcH3Fmr0U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727879AbgA1OJp (ORCPT ); Tue, 28 Jan 2020 09:09:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:58190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727414AbgA1OJm (ORCPT ); Tue, 28 Jan 2020 09:09:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FFFA24695; Tue, 28 Jan 2020 14:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220581; bh=hGE2T1G6lPIGWI7NEOMKzgp80gd/lwiRHwpdPFENheY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PzyQmWuuPoR1NHNUE2EoCbisL5KUDr8gFrxbwZ7AsI1pAJa0fhvpQHX+RjsoTaoQO slpCz3YN90RNDMaZV2hCDyfgpcr5IP3/nYhvMavsWAp1H4cvzZKRjEAE8QPR6YjzEK 0DgKhWXc0TbQ+Mw4rWjFJLaoi6HFwIXVtomgmJvI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 063/183] media: wl128x: Fix an error code in fm_download_firmware() Date: Tue, 28 Jan 2020 15:04:42 +0100 Message-Id: <20200128135836.297556746@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 ] We forgot to set "ret" on this error path. Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/radio/wl128x/fmdrv_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c index 51639a3f7abe4..0cee10cca0e57 100644 --- a/drivers/media/radio/wl128x/fmdrv_common.c +++ b/drivers/media/radio/wl128x/fmdrv_common.c @@ -1278,8 +1278,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name) switch (action->type) { case ACTION_SEND_COMMAND: /* Send */ - if (fmc_send_cmd(fmdev, 0, 0, action->data, - action->size, NULL, NULL)) + ret = fmc_send_cmd(fmdev, 0, 0, action->data, + action->size, NULL, NULL); + if (ret) goto rel_fw; cmd_cnt++; -- 2.20.1