From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC610C2D0DB for ; Tue, 28 Jan 2020 14:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EF9820716 for ; Tue, 28 Jan 2020 14:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222349; bh=os7H21hXs8WMcYHpup+mf+HpJ4YSlaMOYYiP6Ir8qHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CV5d3jycXxW7hEBOnhYpQeWGEZ72hBnr8WqJutugISafUDus9wP9YVBpHnjH+G8x2 AcoYjMIEOCpj53W19alA1WK9rjhxTVYlPwnJLerdwFACGER/c6UOZFht7gBya6MUCL 2CeWTKqm1/dCubfxKnO/4emeCKMji7iUmV4WWB10= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731442AbgA1OjI (ORCPT ); Tue, 28 Jan 2020 09:39:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:41728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730576AbgA1ORw (ORCPT ); Tue, 28 Jan 2020 09:17:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A81F02071E; Tue, 28 Jan 2020 14:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221072; bh=os7H21hXs8WMcYHpup+mf+HpJ4YSlaMOYYiP6Ir8qHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zMX3cYfrHEY/lWBNsGJ+NMTDNEbmXybG2z+ZjuWzF0Fz9OONjcISI1YgwGaGiQSt5 TJmBWrNd3DtNIf6tiwEssOpf+NFh0x+KBERJLoIkqT43TTnlwzU1lLG4XVYBBYrTnh wbtl4Zou6b3NjcudzAkBuBE2mshbfqYSXsQ1SsQY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH 4.9 078/271] regulator: pv88060: Fix array out-of-bounds access Date: Tue, 28 Jan 2020 15:03:47 +0100 Message-Id: <20200128135858.363147358@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 7cd415f875591bc66c5ecb49bf84ef97e80d7b0e ] Fix off-by-one while iterating current_limits array. The valid index should be 0 ~ n_current_limits -1. Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver") Signed-off-by: Axel Lin Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pv88060-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/regulator/pv88060-regulator.c index 6c4afc73ecac3..d229245d2b5e8 100644 --- a/drivers/regulator/pv88060-regulator.c +++ b/drivers/regulator/pv88060-regulator.c @@ -135,7 +135,7 @@ static int pv88060_set_current_limit(struct regulator_dev *rdev, int min, int i; /* search for closest to maximum */ - for (i = info->n_current_limits; i >= 0; i--) { + for (i = info->n_current_limits - 1; i >= 0; i--) { if (min <= info->current_limits[i] && max >= info->current_limits[i]) { return regmap_update_bits(rdev->regmap, -- 2.20.1