From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE07C2D0DB for ; Tue, 28 Jan 2020 14:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3B9B2468F for ; Tue, 28 Jan 2020 14:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221226; bh=dOS2yNZCnC+oUXIGxeAJhoVIsP9f/hRtOGR5yWq3los=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2QznA4oqg5BJlsZ+Q+KcPNmljAyPLIzRK5e7Rcm3Ums/boiEWsbFh9Co0z8UhDk1P 76h/sdOKfeM91udoSJqVVZkhheJNJvuFQZTFM7mnlVOuwbZgwBIHueRsmvyNuhFV9X jFqVF2oeEEpX5ZLnrKomh2q6lsuK3a48midlibDw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730466AbgA1OUZ (ORCPT ); Tue, 28 Jan 2020 09:20:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:45216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730832AbgA1OUV (ORCPT ); Tue, 28 Jan 2020 09:20:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE3B624681; Tue, 28 Jan 2020 14:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580221221; bh=dOS2yNZCnC+oUXIGxeAJhoVIsP9f/hRtOGR5yWq3los=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wRgkJ7w+vEkVmE3nHSjU9MZCKIpPOWEaSnGp/TuqNHvyQyfb1MnLzuK/HP61QAzFe ipGaguRr1ZqTEesTTvEUijZYkbDpt/L7ek15kpyNDm+o0MtESkFJJnMkySexwfUzm1 GFfy7qAvdxP4Jyq8wy9q/5bah8KUTIuo11iDDP6M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mario Limonciello , Andy Shevchenko , Sasha Levin Subject: [PATCH 4.9 137/271] platform/x86: alienware-wmi: printing the wrong error code Date: Tue, 28 Jan 2020 15:04:46 +0100 Message-Id: <20200128135902.786270718@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135852.449088278@linuxfoundation.org> References: <20200128135852.449088278@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ] The "out_data" variable is uninitialized at the point. Originally, this used to print "status" instead and that seems like the correct thing to print. Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status") Signed-off-by: Dan Carpenter Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/alienware-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index fe419935041c1..bee2115ecf101 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -570,7 +570,7 @@ static ssize_t show_hdmi_source(struct device *dev, return scnprintf(buf, PAGE_SIZE, "input [gpu] unknown\n"); } - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data); + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status); return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n"); } -- 2.20.1