From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C17C2D0DB for ; Wed, 29 Jan 2020 14:46:54 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 093B4206F0 for ; Wed, 29 Jan 2020 14:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 093B4206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB1D51BFF5; Wed, 29 Jan 2020 15:46:52 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 90F8D1BFF4 for ; Wed, 29 Jan 2020 15:46:51 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 06:46:50 -0800 X-IronPort-AV: E=Sophos;i="5.70,378,1574150400"; d="scan'208";a="222471194" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.97]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Jan 2020 06:46:47 -0800 Date: Wed, 29 Jan 2020 14:46:44 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Neil Horman , Cristian Dumitrescu , Eelco Chaudron , dev@dpdk.org, Thomas Monjalon , Luca Boccassi , David Marchand , Ian Stokes Message-ID: <20200129144644.GA368@bricha3-MOBL.ger.corp.intel.com> References: <20200129122953.2016199-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200129122953.2016199-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 29, 2020 at 12:29:53PM +0000, Ferruh Yigit wrote: > Duplicated the existing symbol and versioned one as experimental and > other as stable. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the symbol is in EXPERIMENTAL tag in .map file but it > is not in the .experimental section (__rte_experimental tag is missing). > Updated tool in a way it won't complain if the symbol in the > EXPERIMENTAL tag duplicated in some other block in .map file (versioned) > > Updated meson build system to allow the versioning, > 'use_function_versioning = true', not sure why it was disabled by > default. > Because when enabled everything in the library must be built twice - once for static lib and differently for a dynamic lib. Therefore unless a library actually needs versioned symbols, we only build everything once to save on build time. /Bruce