Re: [PATCH 0/2] ppc/pnv: Add models for PHB4 and PHB3 PCIe Host bridges

From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Oliver O'Halloran <oohall@gmail.com>,
	qemu-devel@nongnu.org, Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 0/2] ppc/pnv: Add models for PHB4 and PHB3 PCIe Host bridges
Date: Thu, 30 Jan 2020 09:14:44 +1100	[thread overview]
Message-ID: <20200129221444.GA2640@umbus.fritz.box> (raw)
In-Reply-To: <ad66cad0-98ff-7ab1-9be9-8bc234279ff6@kaod.org>

[-- Attachment #1: Type: text/plain, Size: 2863 bytes --]

On Wed, Jan 29, 2020 at 02:15:35PM +0100, Cédric Le Goater wrote:
> On 1/29/20 7:31 AM, David Gibson wrote:
> > On Mon, Jan 27, 2020 at 03:45:04PM +0100, Cédric Le Goater wrote:
> >> Hello,
> >>
> >> These are models for the PCIe Host Bridges, PHB3 and PHB4, as found on
> >> POWER8 and POWER9 processors. It includes the PowerBus logic interface
> >> (PBCQ), IOMMU support, a single PCIe Gen.3/4 Root Complex, and support
> >> for MSI and LSI interrupt sources as found on each system depending on
> >> the interrupt controller: XICS or XIVE.
> >>
> >> No default device layout is provided and PCI devices can be added on
> >> any of the available PCIe Root Port (pcie.0 .. 2) with address 0x0 as
> >> the firwware (skiboot) only accepts a single device per root port. To
> >> run a simple system with a network and a storage adapters, use a
> >> command line options such as :
> >>
> >>   -device e1000e,netdev=net0,mac=C0:FF:EE:00:00:02,bus=pcie.0,addr=0x0
> >>   -netdev bridge,id=net0,helper=/usr/libexec/qemu-bridge-helper,br=virbr0,id=hostnet0
> >>
> >>   -device megasas,id=scsi0,bus=pcie.1,addr=0x0
> >>   -drive file=$disk,if=none,id=drive-scsi0-0-0-0,format=qcow2,cache=none
> >>   -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,id=scsi0-0-0-0,bootindex=2
> >>
> >> If more are needed, include a bridge.
> >>
> >> Multi chip is supported, each chip adding its set of PHB controllers
> >> and its PCI busses. The model doesn't emulate the EEH error handling
> >> and cold plugging PHB devices still needs some work.
> >>
> >> XICS requires some adjustment to support the PHB3 MSI. The changes are
> >> provided in the PHB3 model but they could be decoupled in prereq
> >> patches.
> > 
> > Applied to ppc-for-5.0, thanks.
> 
> Should we add a default set of devices on PHB1 like found on OpenPOWER 
> system ? On a P8 we have  :

I think that's kind of up to you.

> 
>  +-[0001:00]---00.0-[01-07]----00.0-[02-07]--+-01.0-[03-04]----00.0-[04]----00.0  ASPEED Technology, Inc. ASPEED Graphics Family
>  |                                           +-02.0-[05]----00.0  Texas Instruments TUSB73x0 SuperSpeed USB 3.0 xHCI Host Controller
>  |                                           +-03.0-[06]--+-00.0  Broadcom Inc. and subsidiaries NetXtreme BCM5718 Gigabit Ethernet PCIe
>  |                                           |            \-00.1  Broadcom Inc. and subsidiaries NetXtreme BCM5718 Gigabit Ethernet PCIe
>  |                                           \-04.0-[07]----00.0  Marvell Technology Group Ltd. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller
> 
> 
> C.
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]