From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35129C2D0DB for ; Thu, 30 Jan 2020 18:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02544214AF for ; Thu, 30 Jan 2020 18:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580410016; bh=vLl1+z6hqSi6GBnz1nn3dYlO3YxHBtltxog8ULeao+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HsVFf98LyqTEpXl/AeDg9wJcMDSAKkb+HVb5GCZkv4I2i95mFVN2pvods6rms6hUu CbOC4XFkhwKCyG45DKTfnEppVBjDGm6FSuolWcqtpRRaKRwaF3L603WJHx/7Hu3qQJ aHH8Nk4KUPtxxwtGBzp/gQCGskiwNngnXvnYUia8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731035AbgA3Sqz (ORCPT ); Thu, 30 Jan 2020 13:46:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:57158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731277AbgA3Sqx (ORCPT ); Thu, 30 Jan 2020 13:46:53 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96A21214AF; Thu, 30 Jan 2020 18:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580410013; bh=vLl1+z6hqSi6GBnz1nn3dYlO3YxHBtltxog8ULeao+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfL2VU9lLmHEhTIgb7YLSNh0jLwmgbPCQFwXOdqiYsj4KLzDH14ODFbfrDFZwG5fn FsPMJMUlU5G6odiXbeioN4ff2tnPKHPafzKPcxec3W+IQfgBGZulDm6HZHUJR1gVqB jB1SEQGIhQSJEIHsm2UNQ02N9DFH2i0ndpS7Zyoo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.19 04/55] USB: serial: ir-usb: add missing endpoint sanity check Date: Thu, 30 Jan 2020 19:38:45 +0100 Message-Id: <20200130183609.443071407@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200130183608.563083888@linuxfoundation.org> References: <20200130183608.563083888@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 2988a8ae7476fe9535ab620320790d1714bdad1d upstream. Add missing endpoint sanity check to avoid dereferencing a NULL-pointer on open() in case a device lacks a bulk-out endpoint. Note that prior to commit f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework") the oops would instead happen on open() if the device lacked a bulk-in endpoint and on write() if it lacked a bulk-out endpoint. Fixes: f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework") Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/ir-usb.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/serial/ir-usb.c +++ b/drivers/usb/serial/ir-usb.c @@ -195,6 +195,9 @@ static int ir_startup(struct usb_serial struct usb_irda_cs_descriptor *irda_desc; int rates; + if (serial->num_bulk_in < 1 || serial->num_bulk_out < 1) + return -ENODEV; + irda_desc = irda_usb_find_class_desc(serial, 0); if (!irda_desc) { dev_err(&serial->dev->dev,