From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF66C2D0DB for ; Thu, 30 Jan 2020 18:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E736215A4 for ; Thu, 30 Jan 2020 18:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580409677; bh=NkzPDC3WmqTpG5Q3lK/TWMmu0KCXkzpL1LCZ44XdnZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=do9KL2BoOhR/8CNIqCzMGaXQnLfmBYr1VaikBvPUo52ArKfyAS2+26GP4bCMWbe7H T8oqFuZbUS1WjIzcn3NYY9EhGNGF8LHz8b5Uwk9owXKCGhHIoFk2yRAm5LfA32OHOu 2ZXRzuLiDlmGofX1NTOCyKHh/+w6FTvNI8yGrw6k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730127AbgA3SlQ (ORCPT ); Thu, 30 Jan 2020 13:41:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:48926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730088AbgA3SlG (ORCPT ); Thu, 30 Jan 2020 13:41:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43D6E2083E; Thu, 30 Jan 2020 18:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580409665; bh=NkzPDC3WmqTpG5Q3lK/TWMmu0KCXkzpL1LCZ44XdnZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J+z5EEmNle5FjCsy3HURLDD9WdASBtRt9VQCd0HzbJs+RZuDzcMDA/IGEN0NU4EAF 1BNhkoE1pWBfNTHzNYD36MayACcnGTdkD2FONeTISipnR8RdMSLYfDke0gtM8luHED LOlnU4nalonLJue31m6bbugMfR+zyjKov7ZUddmc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jes Sorensen , Johan Hovold , Kalle Valo Subject: [PATCH 5.5 34/56] rtl8xxxu: fix interface sanity check Date: Thu, 30 Jan 2020 19:38:51 +0100 Message-Id: <20200130183615.238289079@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200130183608.849023566@linuxfoundation.org> References: <20200130183608.849023566@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 39a4281c312f2d226c710bc656ce380c621a2b16 upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") Cc: stable # 4.4 Cc: Jes Sorensen Signed-off-by: Johan Hovold Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -6384,7 +6384,7 @@ static int rtl8xxxu_parse_usb(struct rtl u8 dir, xtype, num; int ret = 0; - host_interface = &interface->altsetting[0]; + host_interface = interface->cur_altsetting; interface_desc = &host_interface->desc; endpoints = interface_desc->bNumEndpoints;