From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] fuse: Convert from readpages to readahead
Date: Fri, 31 Jan 2020 13:19:09 +1100 [thread overview]
Message-ID: <20200131021909.GC18575@dread.disaster.area> (raw)
In-Reply-To: <20200130213533.GN6615@bombadil.infradead.org>
On Thu, Jan 30, 2020 at 01:35:33PM -0800, Matthew Wilcox wrote:
> On Wed, Jan 29, 2020 at 12:08:29PM +1100, Dave Chinner wrote:
> > On Fri, Jan 24, 2020 at 05:35:52PM -0800, Matthew Wilcox wrote:
> > > + while (nr_pages--) {
> > > + struct page *page = readahead_page(mapping, start++);
> > > + int err = fuse_readpages_fill(&data, page);
> > > +
> > > + if (!err)
> > > + continue;
> > > + nr_pages++;
> > > + goto out;
> > > }
> >
> > That's some pretty convoluted logic. Perhaps:
> >
> > for (; nr_pages > 0 ; nr_pages--) {
> > struct page *page = readahead_page(mapping, start++);
> >
> > if (fuse_readpages_fill(&data, page))
> > goto out;
> > }
>
> I have a bit of an aversion to that style of for loop ... I like this
> instead:
>
> while (nr_pages) {
> struct page *page = readahead_page(mapping, start++);
>
> if (fuse_readpages_fill(&data, page) != 0)
> goto out;
> nr_pages--;
> }
yup, that's also fine.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-01-31 2:19 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 1:35 [PATCH 00/12] Change readahead API Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 01/12] mm: Fix the return type of __do_page_cache_readahead Matthew Wilcox
2020-01-25 1:35 ` [PATCH 02/12] readahead: Ignore return value of ->readpages Matthew Wilcox
2020-01-25 1:35 ` [PATCH 03/12] readahead: Put pages in cache earlier Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 19:44 ` Matthew Wilcox
2020-01-25 19:44 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 19:44 ` Matthew Wilcox
2020-01-25 19:44 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 04/12] mm: Add readahead address space operation Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 3:57 ` Randy Dunlap
2020-01-25 3:57 ` [Cluster-devel] " Randy Dunlap
2020-01-25 3:57 ` Randy Dunlap
2020-01-25 3:57 ` [f2fs-dev] " Randy Dunlap
2020-02-01 0:25 ` Matthew Wilcox
2020-02-01 0:25 ` [Cluster-devel] " Matthew Wilcox
2020-02-01 0:25 ` Matthew Wilcox
2020-02-01 0:25 ` [f2fs-dev] " Matthew Wilcox
2020-01-29 0:24 ` Dave Chinner
2020-01-29 0:24 ` [Cluster-devel] " Dave Chinner
2020-01-29 0:24 ` Dave Chinner
2020-01-29 0:24 ` [f2fs-dev] " Dave Chinner
2020-01-29 0:24 ` [Ocfs2-devel] " Dave Chinner
2020-01-30 8:00 ` Matthew Wilcox
2020-01-30 8:00 ` [Cluster-devel] " Matthew Wilcox
2020-01-30 8:00 ` Matthew Wilcox
2020-01-30 8:00 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 05/12] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 06/12] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-01-29 0:46 ` Dave Chinner
2020-01-30 8:09 ` Matthew Wilcox
2020-01-31 2:17 ` Dave Chinner
2020-01-25 1:35 ` [PATCH 07/12] erofs: Convert uncompressed files " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:53 ` Gao Xiang
2020-01-25 1:53 ` Gao Xiang via Linux-erofs
2020-01-25 19:09 ` Matthew Wilcox
2020-01-29 0:57 ` Dave Chinner
2020-01-29 0:57 ` Dave Chinner
2020-01-30 8:10 ` Matthew Wilcox
2020-01-30 8:10 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 08/12] erofs: Convert compressed " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 09/12] ext4: Convert " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 10/12] f2fs: " Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 11/12] fuse: " Matthew Wilcox
2020-01-29 1:08 ` Dave Chinner
2020-01-30 21:35 ` Matthew Wilcox
2020-01-31 2:19 ` Dave Chinner [this message]
2020-01-29 10:50 ` Miklos Szeredi
2020-01-29 10:50 ` Miklos Szeredi
2020-01-30 7:26 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 12/12] iomap: " Matthew Wilcox
2020-01-29 1:38 ` Dave Chinner
2020-01-31 9:44 ` Matthew Wilcox
2020-02-13 4:38 ` [PATCH 00/12] Change readahead API Andrew Morton
2020-02-13 4:38 ` [Cluster-devel] " Andrew Morton
2020-02-13 4:38 ` Andrew Morton
2020-02-13 4:38 ` [f2fs-dev] " Andrew Morton
2020-02-13 4:38 ` [Ocfs2-devel] " Andrew Morton
2020-02-13 13:43 ` Matthew Wilcox
2020-02-13 13:43 ` [Cluster-devel] " Matthew Wilcox
2020-02-13 13:43 ` Matthew Wilcox
2020-02-13 13:43 ` [f2fs-dev] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131021909.GC18575@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.