From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6666C3F68F for ; Fri, 31 Jan 2020 06:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACE0C21734 for ; Fri, 31 Jan 2020 06:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgAaG47 (ORCPT ); Fri, 31 Jan 2020 01:56:59 -0500 Received: from sauhun.de ([88.99.104.3]:56920 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgAaG46 (ORCPT ); Fri, 31 Jan 2020 01:56:58 -0500 Received: from localhost (p54B333AF.dip0.t-ipconnect.de [84.179.51.175]) by pokefinder.org (Postfix) with ESMTPSA id 721C42C0830; Fri, 31 Jan 2020 07:56:55 +0100 (CET) Date: Fri, 31 Jan 2020 07:56:55 +0100 From: Wolfram Sang To: Alain Volmat Cc: robh+dt@kernel.org, mark.rutland@arm.com, pierre-yves.mordret@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com Subject: Re: [PATCH 5/6] i2c: i2c-stm32f7: allow controller to be wakeup-source Message-ID: <20200131065654.GB1028@ninjato> References: <1578317314-17197-1-git-send-email-alain.volmat@st.com> <1578317314-17197-6-git-send-email-alain.volmat@st.com> <20200130083927.GH2208@ninjato> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline In-Reply-To: <20200130083927.GH2208@ninjato> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 30, 2020 at 09:39:27AM +0100, Wolfram Sang wrote: > On Mon, Jan 06, 2020 at 02:28:33PM +0100, Alain Volmat wrote: > > Allow the i2c-stm32f7 controller to become a wakeup-source > > of the system. In such case, when a slave is registered to the > > I2C controller, receiving a I2C message targeting that registered > > slave address wakes up the suspended system. > >=20 > > In order to be able to wake-up, the I2C controller DT node > > must have the property wakeup-source defined and a slave > > must be registered. > >=20 > > Signed-off-by: Alain Volmat >=20 > Applied to for-next, thanks! And I will drop it again because buildbot rightfully complains: > Reported-by: kbuild test robot >=20 > All errors (new ones prefixed by >>): >=20 > drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_suspend': > >> drivers/i2c/busses/i2c-stm32f7.c:2199:44: error: 'struct dev_pm_info' = has no member named 'wakeup_path' > if (!device_may_wakeup(dev) && !dev->power.wakeup_path) { > ^ > drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_resume': > drivers/i2c/busses/i2c-stm32f7.c:2218:44: error: 'struct dev_pm_info' = has no member named 'wakeup_path' > if (!device_may_wakeup(dev) && !dev->power.wakeup_path) { > ^ wakeup_path is only there if CONFIG_PM. Please fix and send a new version. --kORqDWCi7qDJ0mEj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4zz7YACgkQFA3kzBSg KbaWShAAsD5Gaj6lEFcuVH415Va4PzT6S2H3CUZIfq7iTBdNKWV8nvABcAaS18FA WY9qmpili5WRVugYU+1X4rxzEnSPiO6Sx5s9HGZHPefRlr2B99BknwPRCRkwWb6g vGNROAZh+qQuTayJ2UH33dSGtjXQ09KH4uDrIeRBoxWRuOlhxOe1FBmwudzEC4UM g3nCUq94rccym19fNkWxATy1RCwd2LZF4RRjj2CQLW+o41hUa/Vtb953oxjKPZHo p6lNncLSls4myb0yyqLEfnyFgOaopM7kOaTsgZAElto7WptLPtrcv0M6pCuZGeQx jFEqtZqSGNQsnlv4kZIei/Cnwp/zP1wgsHblLH20w1AuKAwq0G91kysEIH6OYak/ HUL09BSJ25ZVEKDOonq/bIVPlxSvO5C0SYkq+YjgY5ojSCWWLF8ThkUCayynCEu1 qsLn6oY7bB/8qqpiqPb+rx6M5ZuLLz3RKQmv28WuV2Oyl/KPgjtBXQ4KDG8l5fxI bUGHLyMdiyGFoK64lppvjAWp3WSsN8IvcVfRrl7HfTgZ+iGONbCs+ZYVQ9Y3i1gw APQl4R/vack7OumxG6wFjRvEpPDfwDvaR6A4yxpi62mp+YwP9NZ93pduvhqrF/DB XMvJqyy4aMLZFDC1ioWldHX8FuFEXLqc2BULX/o0S92ZKSRYVc4= =wM4/ -----END PGP SIGNATURE----- --kORqDWCi7qDJ0mEj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEB7C33CB2 for ; Fri, 31 Jan 2020 06:57:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89A7120705 for ; Fri, 31 Jan 2020 06:57:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JlQFJoEQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89A7120705 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tjv4AOGBrFZR0PFlv7C4MdKmUHOdolAFqb2C0YS7+cg=; b=JlQFJoEQb0zzWquv+JYGaqLK9 rfL2NYcstpLxNWJ9nu1Tcy2x1kOL/PwnJsLFMACgbfiL0goi6ZJcpThWUGzcu3LHAn3pBMWk0Uqc6 9sx7HDqSErZQdOm+LWG6/GK0b0kOdCdleAPTCKLVzkeLIPitboVe++OXZ/I2SOLtQPiLAE1dp1fnK 6kbhS0CfjHPiGm6LvclNkFgoiSYoX4Ikijuuy7mdYSVHvN8+EjoMgIwsa+he2T3xwuJEbclqukVxr FPzBsrKQMr/OvH8tVST+ca+BOlqrpt+jl2WFzvTHP/g9aeFF0xSOW1JAwi8bXXq8KO+BNXAkt2GkX vRIAhhl9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixQEi-0004q0-1Z; Fri, 31 Jan 2020 06:57:04 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ixQEe-0004pK-6j for linux-arm-kernel@lists.infradead.org; Fri, 31 Jan 2020 06:57:02 +0000 Received: from localhost (p54B333AF.dip0.t-ipconnect.de [84.179.51.175]) by pokefinder.org (Postfix) with ESMTPSA id 721C42C0830; Fri, 31 Jan 2020 07:56:55 +0100 (CET) Date: Fri, 31 Jan 2020 07:56:55 +0100 From: Wolfram Sang To: Alain Volmat Subject: Re: [PATCH 5/6] i2c: i2c-stm32f7: allow controller to be wakeup-source Message-ID: <20200131065654.GB1028@ninjato> References: <1578317314-17197-1-git-send-email-alain.volmat@st.com> <1578317314-17197-6-git-send-email-alain.volmat@st.com> <20200130083927.GH2208@ninjato> MIME-Version: 1.0 In-Reply-To: <20200130083927.GH2208@ninjato> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200130_225700_395246_D0C7F7D9 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.torgue@st.com, linux-kernel@vger.kernel.org, pierre-yves.mordret@st.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1056936816586026472==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1056936816586026472== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kORqDWCi7qDJ0mEj" Content-Disposition: inline --kORqDWCi7qDJ0mEj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 30, 2020 at 09:39:27AM +0100, Wolfram Sang wrote: > On Mon, Jan 06, 2020 at 02:28:33PM +0100, Alain Volmat wrote: > > Allow the i2c-stm32f7 controller to become a wakeup-source > > of the system. In such case, when a slave is registered to the > > I2C controller, receiving a I2C message targeting that registered > > slave address wakes up the suspended system. > >=20 > > In order to be able to wake-up, the I2C controller DT node > > must have the property wakeup-source defined and a slave > > must be registered. > >=20 > > Signed-off-by: Alain Volmat >=20 > Applied to for-next, thanks! And I will drop it again because buildbot rightfully complains: > Reported-by: kbuild test robot >=20 > All errors (new ones prefixed by >>): >=20 > drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_suspend': > >> drivers/i2c/busses/i2c-stm32f7.c:2199:44: error: 'struct dev_pm_info' = has no member named 'wakeup_path' > if (!device_may_wakeup(dev) && !dev->power.wakeup_path) { > ^ > drivers/i2c/busses/i2c-stm32f7.c: In function 'stm32f7_i2c_resume': > drivers/i2c/busses/i2c-stm32f7.c:2218:44: error: 'struct dev_pm_info' = has no member named 'wakeup_path' > if (!device_may_wakeup(dev) && !dev->power.wakeup_path) { > ^ wakeup_path is only there if CONFIG_PM. Please fix and send a new version. --kORqDWCi7qDJ0mEj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4zz7YACgkQFA3kzBSg KbaWShAAsD5Gaj6lEFcuVH415Va4PzT6S2H3CUZIfq7iTBdNKWV8nvABcAaS18FA WY9qmpili5WRVugYU+1X4rxzEnSPiO6Sx5s9HGZHPefRlr2B99BknwPRCRkwWb6g vGNROAZh+qQuTayJ2UH33dSGtjXQ09KH4uDrIeRBoxWRuOlhxOe1FBmwudzEC4UM g3nCUq94rccym19fNkWxATy1RCwd2LZF4RRjj2CQLW+o41hUa/Vtb953oxjKPZHo p6lNncLSls4myb0yyqLEfnyFgOaopM7kOaTsgZAElto7WptLPtrcv0M6pCuZGeQx jFEqtZqSGNQsnlv4kZIei/Cnwp/zP1wgsHblLH20w1AuKAwq0G91kysEIH6OYak/ HUL09BSJ25ZVEKDOonq/bIVPlxSvO5C0SYkq+YjgY5ojSCWWLF8ThkUCayynCEu1 qsLn6oY7bB/8qqpiqPb+rx6M5ZuLLz3RKQmv28WuV2Oyl/KPgjtBXQ4KDG8l5fxI bUGHLyMdiyGFoK64lppvjAWp3WSsN8IvcVfRrl7HfTgZ+iGONbCs+ZYVQ9Y3i1gw APQl4R/vack7OumxG6wFjRvEpPDfwDvaR6A4yxpi62mp+YwP9NZ93pduvhqrF/DB XMvJqyy4aMLZFDC1ioWldHX8FuFEXLqc2BULX/o0S92ZKSRYVc4= =wM4/ -----END PGP SIGNATURE----- --kORqDWCi7qDJ0mEj-- --===============1056936816586026472== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1056936816586026472==--