From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC10C2D0DB for ; Fri, 31 Jan 2020 20:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFAD920707 for ; Fri, 31 Jan 2020 20:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="JE4riXF0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbgAaUZD (ORCPT ); Fri, 31 Jan 2020 15:25:03 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:34587 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbgAaUZD (ORCPT ); Fri, 31 Jan 2020 15:25:03 -0500 Received: by mail-pl1-f193.google.com with SMTP id j7so3190583plt.1 for ; Fri, 31 Jan 2020 12:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q5E7ICRfCH/k+vsoYEXnl2y/W56wIiA0Rc0Fphp9Mmg=; b=JE4riXF0b8BiEav4xSlP1fadj/zOT5E3uce1OoNRJkditPZhbB96EPo1F9ZEmDejWu DAF1VqHGdRIQPmwVve/fFazFtDlnkvtv0cHgAMkgqkQe2mUdQL1xkKOQL63l8TnT5hxI 7Tx/bwpyNzKTbx24HqEiH67rHRQMf3bEtlfh2Ldvg9B1FcnQuQGD9pQ0z3diCjrDejm3 EHZdHovYl1YfoEKRC2enwwiAdgDYYoBaBZbXzGHKOImqPDxrTjou+RUBc7ZaUwW1bqHz R2Rdy5jTcgOMePNhRgBD9CHEZiykfJF3pq3L+emfWUSrDQBn36k5aWbJZeCnn4njRgxS Vy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q5E7ICRfCH/k+vsoYEXnl2y/W56wIiA0Rc0Fphp9Mmg=; b=GbbTjXj/8GyoJqZ+G/EjaHdgHLZv3Vy90eDCQPLis3694NnSIojKoO9L/7MWlmuPw8 M+LXC54OUTHW1VJ6QUbUcTk/THVPQ8Hr1mFSeuhPS50bwitS4U6VxpZ9Bv472PVKTObc mneVkqLWGCMY/4QodMyGFUpXiR+OWm0YJmckuMJsO8N2lDM+xgAOs2cU6z3i143GSuZ5 oh2mOX1tYCCe1JlmOTDX1fxYvIP9mMNv6JZlBdahOkC7PJ7BQNrbxSXP20gZnmNuIz+H E5fLxRqhqiVMwREc7y1PQHJN1vNI4cJEfjANdeUnBclRiYrmLOvuC5CdK7heexEKxrhv YfpQ== X-Gm-Message-State: APjAAAWUVUmykce1RNtmpfPrdUjM9EjzQiNgeo6AaVTJppNB3HengJ4Y G6ksyKIcP/quFCxYPH8ANPZI/A== X-Google-Smtp-Source: APXvYqx/rF4SHG+VBC/SpyIUSEV6rkxcTIKcbE+9qgpzFW/cBVySiP8GP2tGaBbjLD4P4fYTsTPuwQ== X-Received: by 2002:a17:902:ac88:: with SMTP id h8mr11712833plr.131.1580502300885; Fri, 31 Jan 2020 12:25:00 -0800 (PST) Received: from vader ([2620:10d:c090:200::2d88]) by smtp.gmail.com with ESMTPSA id g72sm9235976pfb.11.2020.01.31.12.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2020 12:25:00 -0800 (PST) Date: Fri, 31 Jan 2020 12:24:59 -0800 From: Omar Sandoval To: David Howells Cc: linux-fsdevel@vger.kernel.org, Al Viro , kernel-team@fb.com, linux-api@vger.kernel.org, Amir Goldstein , Xi Wang Subject: Re: [RFC PATCH v4 1/4] fs: add flags argument to i_op->link() Message-ID: <20200131202459.GA787405@vader> References: <5b94d23baef8c2a256384f436650f4c4868915a2.1580251857.git.osandov@fb.com> <134625.1580478522@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <134625.1580478522@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jan 31, 2020 at 01:48:42PM +0000, David Howells wrote: > Omar Sandoval wrote: > > > - int (*link) (struct dentry *,struct inode *,struct dentry *); > > + int (*link) (struct dentry *,struct inode *,struct dentry *, int); > > Can you make it unsigned int? > > David > For some reason, the linkat() syscall takes an int, but you're right, might as well make it an unsigned int in the VFS. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Sandoval Subject: Re: [RFC PATCH v4 1/4] fs: add flags argument to i_op->link() Date: Fri, 31 Jan 2020 12:24:59 -0800 Message-ID: <20200131202459.GA787405@vader> References: <5b94d23baef8c2a256384f436650f4c4868915a2.1580251857.git.osandov@fb.com> <134625.1580478522@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <134625.1580478522-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Howells Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Al Viro , kernel-team-b10kYP2dOMg@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Amir Goldstein , Xi Wang List-Id: linux-api@vger.kernel.org On Fri, Jan 31, 2020 at 01:48:42PM +0000, David Howells wrote: > Omar Sandoval wrote: > > > - int (*link) (struct dentry *,struct inode *,struct dentry *); > > + int (*link) (struct dentry *,struct inode *,struct dentry *, int); > > Can you make it unsigned int? > > David > For some reason, the linkat() syscall takes an int, but you're right, might as well make it an unsigned int in the VFS.