From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE50C33CB3 for ; Sat, 1 Feb 2020 19:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40A7B2063A for ; Sat, 1 Feb 2020 19:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580586102; bh=bXDptipJNoM2F1DfQwu3uLE7B64j6EcI8B3qmYqGXk4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ayRGh3oT0f3aqLBBUleoK5puQXXhCflW8KUxMnVnnB9gK+IrrFqQx9+sNucce0BXc ZDfeCEl+xDY2CZqy/nq753EvV9w0TUpJ8IWch7jQXf7lyZ5t43Ua3U+fdeo4oAHvOt xRFgsc/z9xWS6iZdM7rOnpi8krMeBEzmmy48pB/U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbgBATll (ORCPT ); Sat, 1 Feb 2020 14:41:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:40618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbgBATll (ORCPT ); Sat, 1 Feb 2020 14:41:41 -0500 Received: from cakuba.hsd1.ca.comcast.net (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D219205F4; Sat, 1 Feb 2020 19:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580586100; bh=bXDptipJNoM2F1DfQwu3uLE7B64j6EcI8B3qmYqGXk4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gs8GNlvvQRTzcmxYSLcFJYE3pUf9hfJBJp1zEd5gqkVhCW+wzvzBBhQ68idOa3+yQ YrxALgCPkf7k56lGNqmFIc/chMpEP8FUOpFcIiSEaFnKYbecMG4Zq6zoMT+ueieb1i UFVNlGuPuBDejcjVXhOQkIlkl7JpNJiXXn9ex4Us= Date: Sat, 1 Feb 2020 11:41:39 -0800 From: Jakub Kicinski To: Dan Carpenter Cc: Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , "David S. Miller" , Tomasz Duszynski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] octeontx2-pf: Fix an IS_ERR() vs NULL bug Message-ID: <20200201114139.725a6f95@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200131050241.aoqatlxubobkmi4y@kili.mountain> References: <20200131050241.aoqatlxubobkmi4y@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 31 Jan 2020 08:02:41 +0300, Dan Carpenter wrote: > The otx2_mbox_get_rsp() function never returns NULL, it returns error > pointers on error. > > Fixes: 34bfe0ebedb7 ("octeontx2-pf: MTU, MAC and RX mode config support") > Signed-off-by: Dan Carpenter Applied From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Sat, 01 Feb 2020 19:41:39 +0000 Subject: Re: [PATCH net] octeontx2-pf: Fix an IS_ERR() vs NULL bug Message-Id: <20200201114139.725a6f95@cakuba.hsd1.ca.comcast.net> List-Id: References: <20200131050241.aoqatlxubobkmi4y@kili.mountain> In-Reply-To: <20200131050241.aoqatlxubobkmi4y@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , "David S. Miller" , Tomasz Duszynski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, 31 Jan 2020 08:02:41 +0300, Dan Carpenter wrote: > The otx2_mbox_get_rsp() function never returns NULL, it returns error > pointers on error. > > Fixes: 34bfe0ebedb7 ("octeontx2-pf: MTU, MAC and RX mode config support") > Signed-off-by: Dan Carpenter Applied