Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: In file included from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/clk-provider.h:9, from drivers/clk/clk-plldig.c:8: drivers/clk/clk-plldig.c: In function 'plldig_determine_rate': include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:843:48: note: in definition of macro '__is_constexpr' 843 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8))) | ^ include/linux/kernel.h:849:25: note: in expansion of macro '__no_side_effects' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:851:27: note: in definition of macro '__cmp' 851 | #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:851:40: note: in definition of macro '__cmp' 851 | #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:854:10: note: in definition of macro '__cmp_once' 854 | typeof(x) unique_x = (x); \ | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:854:25: note: in definition of macro '__cmp_once' 854 | typeof(x) unique_x = (x); \ | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:145:14: note: in expansion of macro 'clamp' 145 | req->rate = clamp(req->rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ drivers/clk/clk-plldig.c: In function 'plldig_set_rate': include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:843:48: note: in definition of macro '__is_constexpr' 843 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8))) | ^ include/linux/kernel.h:849:25: note: in expansion of macro '__no_side_effects' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:851:27: note: in definition of macro '__cmp' 851 | #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:851:40: note: in definition of macro '__cmp' 851 | #define __cmp(x, y, op) ((x) op (y) ? (x) : (y)) | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:854:10: note: in definition of macro '__cmp_once' 854 | typeof(x) unique_x = (x); \ | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/kernel.h:854:25: note: in definition of macro '__cmp_once' 854 | typeof(x) unique_x = (x); \ | ^ include/linux/kernel.h:868:19: note: in expansion of macro '__careful_cmp' 868 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:28: note: in expansion of macro 'min' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ include/linux/kernel.h:849:4: note: in expansion of macro '__typecheck' 849 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/kernel.h:859:24: note: in expansion of macro '__safe_cmp' 859 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' 875 | #define max(x, y) __careful_cmp(x, y, >) | ^~~~~~~~~~~~~ include/linux/kernel.h:912:45: note: in expansion of macro 'max' 912 | #define clamp(val, lo, hi) min((typeof(val))max(val, lo), hi) | ^~~ drivers/clk/clk-plldig.c:159:9: note: in expansion of macro 'clamp' 159 | rate = clamp(rate, PHI1_MIN_FREQ, PHI1_MAX_FREQ); | ^~~~~ Introduced by commit d37010a3c162 ("clk: ls1028a: Add clock driver for Display output interface") -- Cheers, Stephen Rothwell