From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FFBC35247 for ; Mon, 3 Feb 2020 18:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B61EF2087E for ; Mon, 3 Feb 2020 18:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580753547; bh=tH6dP23ZG3e+YLC5mCuex7PfxrZNkerudkAeVfo+pl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=jl5zGlk++sfptC8Dw4jVllnwT5Q87PaGdmUN+wa7WfVHtCtmVV8RgLXxtMvUKeeOt ZcjclI2DC9XiylGHvbCiU0nEAtfEqOfSyiV8xTRQGLEFifhgjNBYN3IaOg7YMGtJ7L 7XRlEkW34g7HsoVik5l81sg0pn4VV3d+6vd5iFmk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbgBCSM1 (ORCPT ); Mon, 3 Feb 2020 13:12:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:60398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728923AbgBCSM1 (ORCPT ); Mon, 3 Feb 2020 13:12:27 -0500 Received: from cakuba.hsd1.ca.comcast.net (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A13E20838; Mon, 3 Feb 2020 18:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580753546; bh=tH6dP23ZG3e+YLC5mCuex7PfxrZNkerudkAeVfo+pl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oE5qAGilLaW9mCzANqQgSJ3jBpU6l2B5z5t/ca7onBU+OrshiNGwRDwhJEEByv42z 54+KEShdG/OzwcosnBauKyLCVxBgWufiyXvrTGj3sbX7YDuOoFUAA9BHUlLf1fiytH krWRFSQtXgsK36yDnRWnJE3jidGeQImbAbtUCVNU= Date: Mon, 3 Feb 2020 10:12:25 -0800 From: Jakub Kicinski To: Manivannan Sadhasivam Cc: gregkh@linuxfoundation.org, arnd@arndb.de, smohanad@codeaurora.org, jhugo@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v2 14/16] net: qrtr: Add MHI transport layer Message-ID: <20200203101225.43bd27bc@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200131135009.31477-15-manivannan.sadhasivam@linaro.org> References: <20200131135009.31477-1-manivannan.sadhasivam@linaro.org> <20200131135009.31477-15-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 31 Jan 2020 19:20:07 +0530, Manivannan Sadhasivam wrote: > +/* From QRTR to MHI */ > +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev, > + struct mhi_result *mhi_res) > +{ > + struct qrtr_mhi_dev *qdev = dev_get_drvdata(&mhi_dev->dev); > + struct qrtr_mhi_pkt *pkt; > + unsigned long flags; > + > + spin_lock_irqsave(&qdev->ul_lock, flags); > + pkt = list_first_entry(&qdev->ul_pkts, struct qrtr_mhi_pkt, node); > + list_del(&pkt->node); > + complete_all(&pkt->done); > + > + kref_put(&pkt->refcount, qrtr_mhi_pkt_release); Which kref_get() does this pair with? Looks like qcom_mhi_qrtr_send() will release a reference after completion, too. > + spin_unlock_irqrestore(&qdev->ul_lock, flags); > +}