All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Brian Geffon <bgeffon@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-api@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Sonny Rao <sonnyrao@google.com>, Minchan Kim <minchan@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Yu Zhao <yuzhao@google.com>, Jesse Barnes <jsbarnes@google.com>
Subject: Re: [PATCH v2] mm: Add MREMAP_DONTUNMAP to mremap().
Date: Mon, 3 Feb 2020 16:09:40 +0300	[thread overview]
Message-ID: <20200203130940.enfvdsbn42hhoaki@box> (raw)
In-Reply-To: <CADyq12xgnVByYOkL=GcszYYKzDpg254QEOFoW8=e1y=bmOCcFQ@mail.gmail.com>

On Sun, Feb 02, 2020 at 05:17:53AM +0100, Brian Geffon wrote:
> On Wed, Jan 29, 2020 at 11:46 AM Kirill A. Shutemov
> <kirill@shutemov.name> wrote:
> > Any better options for the flag name? (I have none)
> 
> The other option is that it's broken up into two new flags the first
> MREMAP_MUSTMOVE which can be used regardless of whether or not you're
> leaving the original mapping mapped. This would do exactly what it
> describes: move the mapping to a new address with or without
> MREMAP_FIXED, this keeps consistency with MAYMOVE.
> 
> The second flag would be the new MREMAP_DONTUNMAP flag which requires
> MREMAP_MUSTMOVE, again with or without MREMAP_FIXED.
> 
> What are your thoughts on this?

Sounds reasonable.

MREMAP_DONTUNMAP doesn't really convey that you move pages to the new
mapping, but leave empty mapping behind. But I guess there's only so much
you can encode into the name. (Patch to the man page should do the rest)

-- 
 Kirill A. Shutemov

  reply	other threads:[~2020-02-03 13:09 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23  1:46 [PATCH] mm: Add MREMAP_DONTUNMAP to mremap() Brian Geffon
2020-01-23  1:46 ` Brian Geffon
2020-01-23  1:46 ` Brian Geffon
2020-01-23  3:02 ` Andy Lutomirski
2020-01-23  3:02   ` Andy Lutomirski
2020-01-23 18:47   ` Lokesh Gidra
2020-01-23 19:02   ` Brian Geffon
2020-01-23 19:03   ` Brian Geffon
2020-01-23 19:03     ` Brian Geffon
2020-01-24 19:06 ` [PATCH v2] " Brian Geffon
2020-01-24 19:06   ` Brian Geffon
2020-01-24 19:06   ` Brian Geffon
2020-01-26  5:16   ` Nathan Chancellor
2020-01-26  5:16     ` Nathan Chancellor
2020-01-27  2:21     ` Brian Geffon
2020-01-27  2:21       ` Brian Geffon
2020-01-27  2:21       ` Brian Geffon
2020-01-26 22:06   ` Kirill A. Shutemov
2020-01-26 22:06     ` Kirill A. Shutemov
2020-01-28  1:35     ` Brian Geffon
2020-01-28  1:35       ` Brian Geffon
2020-01-29 10:46       ` Kirill A. Shutemov
2020-01-29 10:46         ` Kirill A. Shutemov
2020-02-01 21:03         ` Brian Geffon
2020-02-01 21:03           ` Brian Geffon
2020-02-01 21:03           ` Brian Geffon
2020-02-02  4:17         ` Brian Geffon
2020-02-02  4:17           ` Brian Geffon
2020-02-03 13:09           ` Kirill A. Shutemov [this message]
2020-02-07 20:42             ` Brian Geffon
2020-02-07 20:42               ` Brian Geffon
2020-02-10 10:35               ` Kirill A. Shutemov
2020-02-10 10:35                 ` Kirill A. Shutemov
2020-01-27 10:13   ` Florian Weimer
2020-01-27 10:13     ` Florian Weimer
2020-01-27 10:13     ` Florian Weimer
2020-01-27 22:33     ` Brian Geffon
2020-01-27 22:33       ` Brian Geffon
2020-01-27 22:33       ` Brian Geffon
2020-01-30 12:19       ` Florian Weimer
2020-01-30 12:19         ` Florian Weimer
2020-01-30 12:19         ` Florian Weimer
2020-01-27  4:46 ` [PATCH] " Dan Carpenter
2020-01-27  4:46   ` Dan Carpenter
2020-01-27  4:46   ` Dan Carpenter
2020-01-27  4:46   ` Dan Carpenter
2020-01-27  5:30 ` [PATCH v3] " Brian Geffon
2020-01-27  5:30   ` Brian Geffon
2020-01-27  5:30   ` Brian Geffon
2020-01-28 15:26   ` Will Deacon
2020-01-28 15:26     ` Will Deacon
2020-01-30 10:12     ` Will Deacon
2020-01-30 10:12       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203130940.enfvdsbn42hhoaki@box \
    --to=kirill@shutemov.name \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=bgeffon@google.com \
    --cc=joel@joelfernandes.org \
    --cc=jsbarnes@google.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=sonnyrao@google.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.