From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] set minimum cmake version to 3.10
Date: Mon, 3 Feb 2020 06:27:38 -0800 [thread overview]
Message-ID: <20200203142738.1558715-1-aduskett@gmail.com> (raw)
The CMakeLists.txt file uses the CMP0091 which is an MSVC runtime library flag
abstraction macro.
Because we are not building ninja for Microsoft, it is safe to remove this
macro and set the minimum version to 3.10.
Fixes:
http://autobuild.buildroot.net/results/992b34c5625ec733d8dce678aa7a7540c4768ca1
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
...01-set-minimum-cmake-version-to-3.10.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/ninja/0001-set-minimum-cmake-version-to-3.10.patch
diff --git a/package/ninja/0001-set-minimum-cmake-version-to-3.10.patch b/package/ninja/0001-set-minimum-cmake-version-to-3.10.patch
new file mode 100644
index 0000000000..d75b78fde9
--- /dev/null
+++ b/package/ninja/0001-set-minimum-cmake-version-to-3.10.patch
@@ -0,0 +1,30 @@
+From 4645f74eb668cc1cf876d1e9bef933591da7575c Mon Sep 17 00:00:00 2001
+From: Adam Duskett <aduskett@gmail.com>
+Date: Mon, 3 Feb 2020 06:21:57 -0800
+Subject: [PATCH] set minimum cmake version to 3.10
+
+The CMakeLists.txt file uses the CMP0091 which is an MSVC runtime library flag
+abstraction macro.
+
+Because we are not building ninja for Microsoft, it is safe to remove this
+macro and set the minimum version to 3.10.
+
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ CMakeLists.txt | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 60fd8a1..a040e0b 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,5 +1,4 @@
+-cmake_minimum_required(VERSION 3.15)
+-cmake_policy(SET CMP0091 NEW)
++cmake_minimum_required(VERSION 3.10)
+ project(ninja)
+
+ if(CMAKE_BUILD_TYPE MATCHES "Release")
+--
+2.24.1
+
--
2.24.1
next reply other threads:[~2020-02-03 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 14:27 Adam Duskett [this message]
2020-02-03 14:52 ` [Buildroot] [PATCH 1/1] set minimum cmake version to 3.10 Thomas Petazzoni
2020-02-03 15:13 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203142738.1558715-1-aduskett@gmail.com \
--to=aduskett@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.