From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A139C35247 for ; Mon, 3 Feb 2020 16:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22B992087E for ; Mon, 3 Feb 2020 16:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747370; bh=xRi3OnPDkMrCHrONQoVqFJnmHIAMwnIwbPyrLOZbWDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IhiLxjIx83kqGk5kZ0kpEURY1PBxuTcbugzsN/vS0my6k4aI5a1D4uZFlFhcVg7PQ 1bvauvaty1h+1vGQ3PYCHYKCL2OyEz17PGaxYR2y0FoVMWWZKY8Ae+05+C0JWv8TXH EWJdZMhXyAD/0/sA2bJ+gRXbLzYcWqvn8RT1dgK4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbgBCQ33 (ORCPT ); Mon, 3 Feb 2020 11:29:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:41390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729778AbgBCQ30 (ORCPT ); Mon, 3 Feb 2020 11:29:26 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A1B120CC7; Mon, 3 Feb 2020 16:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747365; bh=xRi3OnPDkMrCHrONQoVqFJnmHIAMwnIwbPyrLOZbWDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UGUPfFga6w2AQL96QWTE/NnbGEkZQy2od1J5KcqmT8XhZw9kdI2ZHJ2iMJQfbL1xt SpzOa9F//ZlLRZae7aeictOTPS+LOGgxEB45rI/UUGMTLFLK2I6BtYE2yNjemJ6bdU ZJJ7iVyHCl38o7PPLkdOdASbD3Rw2BVdsRVzHIpo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , kbuild test robot , Julia Lawall , Lee Jones Subject: [PATCH 4.14 52/89] media: si470x-i2c: Move free() past last use of radio Date: Mon, 3 Feb 2020 16:19:37 +0000 Message-Id: <20200203161923.790810903@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161916.847439465@linuxfoundation.org> References: <20200203161916.847439465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lee Jones A pointer to 'struct si470x_device' is currently used after free: drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference preceded by free on line 460 Shift the call to free() down past its final use. NB: Not sending to Mainline, since the problem does not exist there, it was caused by the backport of 2df200ab234a ("media: si470x-i2c: add missed operations in remove") to the stable trees. Cc: # v3.18+ Reported-by: kbuild test robot Reported-by: Julia Lawall Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -453,10 +453,10 @@ static int si470x_i2c_remove(struct i2c_ free_irq(client->irq, radio); video_unregister_device(&radio->videodev); - kfree(radio); v4l2_ctrl_handler_free(&radio->hdl); v4l2_device_unregister(&radio->v4l2_dev); + kfree(radio); return 0; }