From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ECAC35247 for ; Mon, 3 Feb 2020 16:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D36592087E for ; Mon, 3 Feb 2020 16:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747802; bh=yEAfevoPi1el/pqANxzRHQriIoGQcHdz94DArp8nim0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W9yfll/PMrNYQ3gYBZpQI7VfiSGekJ0Xtn9fbumjrQVu3pC666g4qsDp295m345xa XppLx/3whTz4HI59XUzV2D5rV0rF8BVgYSMulGroKp53CjPo69HZG9b2Y0j+C/tY5G r2XBYky2hGHncrFEJCVCyjQUkwOhALCePAzMswWc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730899AbgBCQgl (ORCPT ); Mon, 3 Feb 2020 11:36:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:51970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731012AbgBCQgh (ORCPT ); Mon, 3 Feb 2020 11:36:37 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4F8F20721; Mon, 3 Feb 2020 16:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747797; bh=yEAfevoPi1el/pqANxzRHQriIoGQcHdz94DArp8nim0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oGhjSnKv1NtBNI/MnNAEIRcJ7sUZy3DxITMpFKxp27eqQ3FEO+IwiEF+DbMes1LVh 7V5M5UyxXaAjhZHdOchuFyjCUXn4bphAaDrH+0eApKqW+Uerw21RU3vhX1Hhos5odA AOwBSCrlojqXm+uhLy8jeAj0K2Pax0OmCbZy+lMM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hayes Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 75/90] r8152: get default setting of WOL before initializing Date: Mon, 3 Feb 2020 16:20:18 +0000 Message-Id: <20200203161926.483033307@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161917.612554987@linuxfoundation.org> References: <20200203161917.612554987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang [ Upstream commit 9583a3638dc07cc1878f41265e85ed497f72efcb ] Initailization would reset runtime suspend by tp->saved_wolopts, so the tp->saved_wolopts should be set before initializing. Signed-off-by: Hayes Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/r8152.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 9e4b7a4002843..df993a1c60c0e 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -5690,6 +5690,11 @@ static int rtl8152_probe(struct usb_interface *intf, intf->needs_remote_wakeup = 1; + if (!rtl_can_wakeup(tp)) + __rtl_set_wol(tp, 0); + else + tp->saved_wolopts = __rtl_get_wol(tp); + tp->rtl_ops.init(tp); queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0); set_ethernet_addr(tp); @@ -5703,10 +5708,6 @@ static int rtl8152_probe(struct usb_interface *intf, goto out1; } - if (!rtl_can_wakeup(tp)) - __rtl_set_wol(tp, 0); - - tp->saved_wolopts = __rtl_get_wol(tp); if (tp->saved_wolopts) device_set_wakeup_enable(&udev->dev, true); else -- 2.20.1