From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DBCC35247 for ; Mon, 3 Feb 2020 16:37:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD9C62087E for ; Mon, 3 Feb 2020 16:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747832; bh=joIDY90KI70QcN/IczlCD1jWOmlxrA4AWRkYSh9Hf1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zY+pnxEtoFppUiYgOEiXRZl+oSAOaRf8wNNtkgE5z8EdhXIsnnEkz45F1NkEAD1d8 dNyp+oH/n2dKk7yPkOhNVmAX/69gm9XzVMbBMxDy1T1XADgWxTfbRmLMiyHZ0JA38a 9N1jqU3EppM8BnNbzPFK9F5pGogIhQDmgKKGRVhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730328AbgBCQhM (ORCPT ); Mon, 3 Feb 2020 11:37:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:52588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731269AbgBCQhG (ORCPT ); Mon, 3 Feb 2020 11:37:06 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26EE620721; Mon, 3 Feb 2020 16:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747825; bh=joIDY90KI70QcN/IczlCD1jWOmlxrA4AWRkYSh9Hf1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U1Vs2U32WHBJmferVjeFFGDCEhh6I2LYDqfhH5DMvC83TSiO4+xhOOREJYnRjXMED DaAQtuE6ZMUveOvpZ6xbLi+n6QYEKmx+rdTn+2dcCVh5maEZbNwZjjoWoIlim3el8r HZ05WD9z5PFHHy3I6NJkMu/OgQ2dDLxI2j7eR4pA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 86/90] seq_tab_next() should increase position index Date: Mon, 3 Feb 2020 16:20:29 +0000 Message-Id: <20200203161927.533931517@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161917.612554987@linuxfoundation.org> References: <20200203161917.612554987@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit 70a87287c821e9721b62463777f55ba588ac4623 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c index fb8ade9a05a97..2ce96cc1bad48 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c @@ -70,8 +70,7 @@ static void *seq_tab_start(struct seq_file *seq, loff_t *pos) static void *seq_tab_next(struct seq_file *seq, void *v, loff_t *pos) { v = seq_tab_get_idx(seq->private, *pos + 1); - if (v) - ++*pos; + ++(*pos); return v; } -- 2.20.1