From: Heyi Guo <guoheyi@huawei.com>
To: <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Heyi Guo <guoheyi@huawei.com>,
wanghaibin.wang@huawei.com
Subject: [PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices
Date: Tue, 4 Feb 2020 09:43:23 +0800 [thread overview]
Message-ID: <20200204014325.16279-6-guoheyi@huawei.com> (raw)
In-Reply-To: <20200204014325.16279-1-guoheyi@huawei.com>
Using _UID of 0 for all PCI interrupt link devices absolutely violates
the spec. Simply increase one by one.
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
Cc: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org
---
hw/arm/virt-acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 5d157a9dd5..f3e340b172 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -189,7 +189,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
uint32_t irqs = irq + i;
Aml *dev_gsi = aml_device("GSI%d", i);
aml_append(dev_gsi, aml_name_decl("_HID", aml_string("PNP0C0F")));
- aml_append(dev_gsi, aml_name_decl("_UID", aml_int(0)));
+ aml_append(dev_gsi, aml_name_decl("_UID", aml_int(i)));
crs = aml_resource_template();
aml_append(crs,
aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,
--
2.19.1
next prev parent reply other threads:[~2020-02-04 1:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 1:43 [PATCH v3 0/7] Some cleanup in arm/virt/acpi Heyi Guo
2020-02-04 1:43 ` [PATCH v3 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT Heyi Guo
2020-02-04 1:43 ` [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0 Heyi Guo
2020-02-04 6:35 ` Michael S. Tsirkin
2020-02-04 1:43 ` [PATCH v3 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID Heyi Guo
2020-02-04 6:35 ` Michael S. Tsirkin
2020-02-04 1:43 ` [PATCH v3 4/7] arm/acpi: fix PCI _PRT definition Heyi Guo
2020-02-04 1:43 ` Heyi Guo [this message]
2020-02-04 1:43 ` [PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS Heyi Guo
2020-02-04 1:43 ` [PATCH v3 7/7] virt/acpi: update golden masters for DSDT update Heyi Guo
2020-02-10 0:30 ` [PATCH v3 0/7] Some cleanup in arm/virt/acpi Heyi Guo
2020-02-11 18:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204014325.16279-6-guoheyi@huawei.com \
--to=guoheyi@huawei.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.