From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5E5C3524A for ; Tue, 4 Feb 2020 07:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B72920674 for ; Tue, 4 Feb 2020 07:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580801797; bh=WUFEjfexfAn28sJ9AUp2kzluNRF9714XTUnJnecywJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Rv5nfw8LtYpD1zQJqPm4aU5p00zZBbZS3L69/QyuZa1SbqO/ZMF8JkCBmqM8tqohu tUfz+XyXYfA8nveJwwSnYPousECOXQJLo6VZeHJyCkE9om9o6nXKNXME+u8ae0AIB7 ikBMuAx5x78Y0Fs1+14zrnUgXifzANI4TvKihP1Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbgBDHgg (ORCPT ); Tue, 4 Feb 2020 02:36:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:59078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbgBDHgg (ORCPT ); Tue, 4 Feb 2020 02:36:36 -0500 Received: from localhost (unknown [167.98.85.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 215DE2087E; Tue, 4 Feb 2020 07:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580801794; bh=WUFEjfexfAn28sJ9AUp2kzluNRF9714XTUnJnecywJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pjoZ2s4RFWiWcb+Nq7LFFuCdqj2UypIjt4yVH5O3VdEpBTSFXD/4MflI22sejvDLy JF8TLK1qCRaNDPw2aHpoH7nt2FMy7MnPRSXB5J99BwczgSR6H/J/GNDxMQwtCaSFsZ NMHXGJm0iKRYf1tMbbdh3DaVmxJSmt0WH5suF59U= Date: Tue, 4 Feb 2020 07:36:32 +0000 From: "gregkh@linuxfoundation.org" To: Chris Packham Cc: "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "wambui.karugax@gmail.com" , "devel@driverdev.osuosl.org" , "julia.lawall@lip6.fr" Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Message-ID: <20200204073632.GB1085438@kroah.com> References: <20191202141836.9363-1-linux@roeck-us.net> <20191202165231.GA728202@kroah.com> <20191202173620.GA29323@roeck-us.net> <20191202181505.GA732872@kroah.com> <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote: > Hi Greg & All, > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > > The code doesn't compile due to incompatible pointer errors > > > > > such as > > > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > > incompatible pointer type > > > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > > cvmx_wqe'. > > > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > > commit, as doing so > > > > > results in secondary errors. This is made worse by the fact > > > > > that the "removed" > > > > > typedefs still exist and are used widely outside the staging > > > > > directory, > > > > > making the entire set of "remove typedef" changes pointless and > > > > > wrong. > > > > > > > > Ugh, sorry about that. > > > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > > > Should I just delete this thing? No one seems to be using it and > > > > there > > > > is no move to get it out of staging at all. > > > > > > > > Will anyone actually miss it? It can always come back of someone > > > > does... > > > > > > > > > > All it does is causing trouble and misguided attempts to clean it > > > up. > > > If anything, the whole thing goes into the wrong direction (declare > > > a > > > complete set of dummy functions just to be able to build the driver > > > with COMPILE_TEST ? Seriously ?). > > > > > > I second the motion to drop it. This has been in staging for 10 > > > years. > > > Don't we have some kind of time limit for code in staging ? If not, > > > should we ? If anyone really needs it, that person or group should > > > really invest the time to get it out of staging for good. > > > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > > -rc1 > > is out. > > > > As a long suffering Cavium MIPs customer could I request that this > isn't dropped. I'll get someone here to take a look at fixing the build > issues. > > Given our platform isn't upstream I'm not sure that we'll be able to > meet the criteria for getting it out of staging. > Can't you push this onto Cavium as you are paying them for hardware and support? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1660BC3524D for ; Tue, 4 Feb 2020 07:36:38 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E058C20674 for ; Tue, 4 Feb 2020 07:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pjoZ2s4R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E058C20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A4E3984FC0; Tue, 4 Feb 2020 07:36:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t3Sw9TqwRKTd; Tue, 4 Feb 2020 07:36:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id D1EFD84FAE; Tue, 4 Feb 2020 07:36:36 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5D1D01BF2B4 for ; Tue, 4 Feb 2020 07:36:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 585DE86DDC for ; Tue, 4 Feb 2020 07:36:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UXXrC8u0hbIF for ; Tue, 4 Feb 2020 07:36:34 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id B652186C3A for ; Tue, 4 Feb 2020 07:36:34 +0000 (UTC) Received: from localhost (unknown [167.98.85.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 215DE2087E; Tue, 4 Feb 2020 07:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580801794; bh=WUFEjfexfAn28sJ9AUp2kzluNRF9714XTUnJnecywJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pjoZ2s4RFWiWcb+Nq7LFFuCdqj2UypIjt4yVH5O3VdEpBTSFXD/4MflI22sejvDLy JF8TLK1qCRaNDPw2aHpoH7nt2FMy7MnPRSXB5J99BwczgSR6H/J/GNDxMQwtCaSFsZ NMHXGJm0iKRYf1tMbbdh3DaVmxJSmt0WH5suF59U= Date: Tue, 4 Feb 2020 07:36:32 +0000 From: "gregkh@linuxfoundation.org" To: Chris Packham Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Message-ID: <20200204073632.GB1085438@kroah.com> References: <20191202141836.9363-1-linux@roeck-us.net> <20191202165231.GA728202@kroah.com> <20191202173620.GA29323@roeck-us.net> <20191202181505.GA732872@kroah.com> <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "julia.lawall@lip6.fr" , "linux-kernel@vger.kernel.org" , "linux@roeck-us.net" , "wambui.karugax@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Feb 04, 2020 at 12:54:26AM +0000, Chris Packham wrote: > Hi Greg & All, > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > > The code doesn't compile due to incompatible pointer errors > > > > > such as > > > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > > incompatible pointer type > > > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > > cvmx_wqe'. > > > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > > commit, as doing so > > > > > results in secondary errors. This is made worse by the fact > > > > > that the "removed" > > > > > typedefs still exist and are used widely outside the staging > > > > > directory, > > > > > making the entire set of "remove typedef" changes pointless and > > > > > wrong. > > > > > > > > Ugh, sorry about that. > > > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > > > Should I just delete this thing? No one seems to be using it and > > > > there > > > > is no move to get it out of staging at all. > > > > > > > > Will anyone actually miss it? It can always come back of someone > > > > does... > > > > > > > > > > All it does is causing trouble and misguided attempts to clean it > > > up. > > > If anything, the whole thing goes into the wrong direction (declare > > > a > > > complete set of dummy functions just to be able to build the driver > > > with COMPILE_TEST ? Seriously ?). > > > > > > I second the motion to drop it. This has been in staging for 10 > > > years. > > > Don't we have some kind of time limit for code in staging ? If not, > > > should we ? If anyone really needs it, that person or group should > > > really invest the time to get it out of staging for good. > > > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > > -rc1 > > is out. > > > > As a long suffering Cavium MIPs customer could I request that this > isn't dropped. I'll get someone here to take a look at fixing the build > issues. > > Given our platform isn't upstream I'm not sure that we'll be able to > meet the criteria for getting it out of staging. > Can't you push this onto Cavium as you are paying them for hardware and support? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel