From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BE3C2D0B1 for ; Tue, 4 Feb 2020 14:04:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB26E22464 for ; Tue, 4 Feb 2020 14:04:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gXxL5y/8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbgBDOEb (ORCPT ); Tue, 4 Feb 2020 09:04:31 -0500 Received: from mail-wm1-f73.google.com ([209.85.128.73]:42237 "EHLO mail-wm1-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727207AbgBDOEa (ORCPT ); Tue, 4 Feb 2020 09:04:30 -0500 Received: by mail-wm1-f73.google.com with SMTP id d4so1214808wmd.7 for ; Tue, 04 Feb 2020 06:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=M5QDlwOFPFeBvx3bqm6hRs2LqKGsL5jmQQoVlW04gqY=; b=gXxL5y/8ZfoayNMAanpmqonkztj0S52rqHHImIicJ4MhhNjd31v/0u+t+Y2lCEwB3t Zrd/23x/Xjx0+g+Dgd/aAFkA6ASHh249rtjiWvc/dsRzgY10FHepBVnCn+gT+vYW9Rsg wLX+HTdvdRWkKslS9QdFL1cRoYBC/l92f/srw+Q3uOctBJR/VPLTOldRXYmqtPknk6Pu /LeRYhvKTYXFqHj0HutDNSGV5aNaGuJxADC5tiTiYiOCAfzfyRPllYx/pv74O+bPep+a KayVQeuq6SWYLqoi6TvPXuSRJhgcgJYFX4Ryoqovfx8yTP6KOUePBc1YGzcd7ftFhPEc C3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=M5QDlwOFPFeBvx3bqm6hRs2LqKGsL5jmQQoVlW04gqY=; b=mR0DaN9oZhAnB2eRSIVNna6kmm9udCBhaaa0rQfqtsiapSQhUS2DUTj9LU5Xg9FMdo kU7i5tRN7HZrQVO8GKlJGzXwH47ehaKrEBQpUUa0odoFtsXldVbLt/MbYcaUNh2MT1Rk f2oNhm1dHDTZwOqbdHQp/A82IeQW5hcCA/Wz68qdB4aQPdvncmLK+l1hQ6PePbt/Bb+N zYLFnxNjUJn45V0HQJYnleI3u6Gg3tmyNA0hC5oOzJVSkm8IP7HLhipTW40g/xjuU/ND idZemZbVXyfr5iCRQfatWlJS/uP+z4F4ZT9rIrQ4aqhJ0oGK1kpHJoMJZea9peiNHWaq PprQ== X-Gm-Message-State: APjAAAWD43DZ/vSCmxb09lZUlAPM/gc1bn4w4hKKxReMbjNmrxTOv38L /tCvHguViUexMmwqmACUslBpRPhTEw== X-Google-Smtp-Source: APXvYqxKXMV8rmeLGLDkEfmXBf+98I1ti+BY60d88Xy7gAfqeTiHL6Th4QBvxdjjVZBKP99VcfUCl4F1Pg== X-Received: by 2002:a5d:4052:: with SMTP id w18mr16149162wrp.112.1580825068609; Tue, 04 Feb 2020 06:04:28 -0800 (PST) Date: Tue, 4 Feb 2020 15:03:53 +0100 In-Reply-To: <20200204140353.177797-1-elver@google.com> Message-Id: <20200204140353.177797-3-elver@google.com> Mime-Version: 1.0 References: <20200204140353.177797-1-elver@google.com> X-Mailer: git-send-email 2.25.0.341.g760bfbb309-goog Subject: [PATCH 3/3] kcsan: Cleanup of main KCSAN Kconfig option From: Marco Elver To: elver@google.com Cc: paulmck@kernel.org, andreyknvl@google.com, glider@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch cleans up the rules of the 'KCSAN' Kconfig option by: 1. implicitly selecting 'STACKTRACE' instead of depending on it; 2. depending on DEBUG_KERNEL, to avoid accidentally turning KCSAN on if the kernel is not meant to be a debug kernel; 3. updating the short and long summaries. Signed-off-by: Marco Elver --- lib/Kconfig.kcsan | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan index 35fab63111d75..0af6301061c03 100644 --- a/lib/Kconfig.kcsan +++ b/lib/Kconfig.kcsan @@ -4,12 +4,15 @@ config HAVE_ARCH_KCSAN bool menuconfig KCSAN - bool "KCSAN: watchpoint-based dynamic data race detector" - depends on HAVE_ARCH_KCSAN && !KASAN && STACKTRACE + bool "KCSAN: dynamic data race detector" + depends on HAVE_ARCH_KCSAN && DEBUG_KERNEL && !KASAN + select STACKTRACE help - Kernel Concurrency Sanitizer is a dynamic data race detector, which - uses a watchpoint-based sampling approach to detect races. See - for more details. + The Kernel Concurrency Sanitizer (KCSAN) is a dynamic data race + detector, which relies on compile-time instrumentation, and uses a + watchpoint-based sampling approach to detect data races. + + See for more details. if KCSAN -- 2.25.0.341.g760bfbb309-goog