From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] package/pkg-meson: use TARGET_MAKE_ENV in configure
Date: Tue, 4 Feb 2020 15:24:56 +0100 [thread overview]
Message-ID: <20200204142456.1537358-6-arnout@mind.be> (raw)
In-Reply-To: <20200204142456.1537358-1-arnout@mind.be>
The configure step doesn't use TARGET_MAKE_ENV, but sets PATH
explicitly. Thus, it missed the update of PATH with HOST_BIN_CROSS.
Instead of adding it explicitly again, just use TARGET_MAKE_ENV. Yes,
it's not really a 'make environment' that we're expecting to use in the
configure step, 'conf environment' would make more sense. However,
TARGET_MAKE_ENV is indeed used in the configure step since it's part of
TARGET_CONFIGURE_OPTS.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/pkg-meson.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
index e7eea2aa58..7bb08157f5 100644
--- a/package/pkg-meson.mk
+++ b/package/pkg-meson.mk
@@ -84,7 +84,7 @@ define $(2)_CONFIGURE_CMDS
) \
package/meson/cross-compilation.conf.in \
> $$($$(PKG)_SRCDIR)/build/cross-compilation.conf
- PATH=$$(BR_PATH) $$($$(PKG)_CONF_ENV) $$(MESON) \
+ $$(TARGET_MAKE_ENV) $$($$(PKG)_CONF_ENV) $$(MESON) \
--prefix=/usr \
--libdir=lib \
--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
--
2.24.1
next prev parent reply other threads:[~2020-02-04 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 14:24 [Buildroot] [PATCH 0/5] [RFC] Introduce cross-bin directory Arnout Vandecappelle
2020-02-04 14:24 ` [Buildroot] [PATCH 1/5] package/Makefile.in: add HOST_BIN_CROSS Arnout Vandecappelle
2020-02-04 14:24 ` [Buildroot] [PATCH 2/5] package/python3: install wrapper in HOST_BIN_CROSS Arnout Vandecappelle
2020-02-04 14:24 ` [Buildroot] [PATCH 3/5] package/python: " Arnout Vandecappelle
2020-02-04 14:24 ` [Buildroot] [PATCH 4/5] package/pkg-python: rely on python " Arnout Vandecappelle
2020-02-04 14:24 ` Arnout Vandecappelle [this message]
2020-02-04 15:15 ` [Buildroot] [PATCH 0/5] [RFC] Introduce cross-bin directory Arnout Vandecappelle
2021-05-26 18:45 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204142456.1537358-6-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.