From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB041C3524D for ; Tue, 4 Feb 2020 15:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93F702082E for ; Tue, 4 Feb 2020 15:21:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbgBDPVo (ORCPT ); Tue, 4 Feb 2020 10:21:44 -0500 Received: from foss.arm.com ([217.140.110.172]:38078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727369AbgBDPVn (ORCPT ); Tue, 4 Feb 2020 10:21:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDA41101E; Tue, 4 Feb 2020 07:21:42 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC71A3F52E; Tue, 4 Feb 2020 07:21:40 -0800 (PST) Date: Tue, 4 Feb 2020 15:21:32 +0000 From: Sudeep Holla To: Maulik Shah Cc: swboyd@chromium.org, agross@kernel.org, david.brown@linaro.org, Lorenzo.Pieralisi@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bjorn.andersson@linaro.org, evgreen@chromium.org, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org, ulf.hansson@linaro.org, rjw@rjwysocki.net, Sudeep Holla Subject: Re: [PATCH v3 5/7] drivers: firmware: psci: Add hierarchical domain idle states converter Message-ID: <20200204152132.GA44858@bogus> References: <1580736940-6985-1-git-send-email-mkshah@codeaurora.org> <1580736940-6985-6-git-send-email-mkshah@codeaurora.org> <20200203170832.GA38466@bogus> <0d7f7ade-3a1e-5428-d851-f1a886f58712@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d7f7ade-3a1e-5428-d851-f1a886f58712@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Feb 04, 2020 at 10:22:42AM +0530, Maulik Shah wrote: > > On 2/3/2020 10:38 PM, Sudeep Holla wrote: > > On Mon, Feb 03, 2020 at 07:05:38PM +0530, Maulik Shah wrote: > > > From: Ulf Hansson > > > > > > If the hierarchical CPU topology is used, but the OS initiated mode isn't > > > supported, we need to rely solely on the regular cpuidle framework to > > > manage the idle state selection, rather than using genpd and its > > > governor. > > > > > > For this reason, introduce a new PSCI DT helper function, > > > psci_dt_pm_domains_parse_states(), which parses and converts the > > > hierarchically described domain idle states from DT, into regular flattened > > > cpuidle states. The converted states are added to the existing cpuidle > > > driver's array of idle states, which make them available for cpuidle. > > > > > And what's the main motivation for this if OSI is not supported in the > > firmware ? > > Hi Sudeep, > > Main motivation is to do last-man activities before the CPU cluster can > enter a deep idle state. > Details on those last-man activities will help the discussion. Basically I am wondering what they are and why they need to done in OSPM ? > > > Signed-off-by: Ulf Hansson > > > [applied to new path, resolved conflicts] > > > Signed-off-by: Maulik Shah > > > --- > > > drivers/cpuidle/cpuidle-psci-domain.c | 137 +++++++++++++++++++++++++++++----- > > > drivers/cpuidle/cpuidle-psci.c | 41 +++++----- > > > drivers/cpuidle/cpuidle-psci.h | 11 +++ > > > 3 files changed, 153 insertions(+), 36 deletions(-) > > > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > > index 423f03b..3c417f7 100644 > > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > > @@ -26,13 +26,17 @@ struct psci_pd_provider { > > > }; > > > > > > static LIST_HEAD(psci_pd_providers); > > > -static bool osi_mode_enabled __initdata; > > > +static bool osi_mode_enabled; > > > > > > static int psci_pd_power_off(struct generic_pm_domain *pd) > > > { > > > struct genpd_power_state *state = &pd->states[pd->state_idx]; > > > u32 *pd_state; > > > > > > + /* If we have failed to enable OSI mode, then abort power off. */ > > > + if ((psci_has_osi_support()) && !osi_mode_enabled) > > > + return -EBUSY; > > > + > > Why is this needed ? IIUC we don't create genpd domains if OSI is not > > enabled. > > we do create genpd domains, for cpu domains, we just abort power off here > since idle states are converted into regular flattened mode. > OK, IIRC the OSI patches from Ulf didn't add the genpd or rather removed them in case of any failure to enable OSI. Has that been changed ? If so, why ? > however genpd poweroff will be used by parent domain (rsc in this case) > which is kept in hireachy in DTSI with cluster domain to do last man > activities. > I am bit confused here. Either we do OSI or PC and what you are describing sounds like a mix-n-match to me and I am totally against it. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB52C35247 for ; Tue, 4 Feb 2020 15:21:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A01242082E for ; Tue, 4 Feb 2020 15:21:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cCEHs1sO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A01242082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8sdlcyG4CIDznTdJNbSsh5SwEFegezp9HACcodrPLSY=; b=cCEHs1sOaWXxyi /Noj9x6a7kgzPh+H/VCKwe5TWz1jTjR753o70vHvsQA4+OmU1WDb6UquCAXf47/DnJ9oJlFkruPDf v5J4IzjvCzQhSY7V+t47IPDoO+/hVSewzkMVOMbNPAvnErpuI0Oqnu5v+hj86rQ+DFaRF9pavM6Sh o6r71cuWv0ri+E4DhqF9fUdqUQ4x1BtZar7HfUjxa3a7d/E9oOcnkhkKi8jzea9JBiQBNhe0zldXL cbrqH7jsbVCy37sjabUMBy2SmL+02/+VYAvHiwh/4DqViIyEPqK+tsrWp39ZCz3j1o7a50rwj4urO kDVsKbxpSn0GSJ2UR8/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iz01O-0001Dc-Aw; Tue, 04 Feb 2020 15:21:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iz01K-0001CZ-1y for linux-arm-kernel@lists.infradead.org; Tue, 04 Feb 2020 15:21:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDA41101E; Tue, 4 Feb 2020 07:21:42 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC71A3F52E; Tue, 4 Feb 2020 07:21:40 -0800 (PST) Date: Tue, 4 Feb 2020 15:21:32 +0000 From: Sudeep Holla To: Maulik Shah Subject: Re: [PATCH v3 5/7] drivers: firmware: psci: Add hierarchical domain idle states converter Message-ID: <20200204152132.GA44858@bogus> References: <1580736940-6985-1-git-send-email-mkshah@codeaurora.org> <1580736940-6985-6-git-send-email-mkshah@codeaurora.org> <20200203170832.GA38466@bogus> <0d7f7ade-3a1e-5428-d851-f1a886f58712@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0d7f7ade-3a1e-5428-d851-f1a886f58712@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200204_072146_187654_F5B143F5 X-CRM114-Status: GOOD ( 23.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dianders@chromium.org, lsrao@codeaurora.org, Lorenzo.Pieralisi@arm.com, rnayak@codeaurora.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, evgreen@chromium.org, swboyd@chromium.org, david.brown@linaro.org, agross@kernel.org, ilina@codeaurora.org, Sudeep Holla , ulf.hansson@linaro.org, bjorn.andersson@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 04, 2020 at 10:22:42AM +0530, Maulik Shah wrote: > > On 2/3/2020 10:38 PM, Sudeep Holla wrote: > > On Mon, Feb 03, 2020 at 07:05:38PM +0530, Maulik Shah wrote: > > > From: Ulf Hansson > > > > > > If the hierarchical CPU topology is used, but the OS initiated mode isn't > > > supported, we need to rely solely on the regular cpuidle framework to > > > manage the idle state selection, rather than using genpd and its > > > governor. > > > > > > For this reason, introduce a new PSCI DT helper function, > > > psci_dt_pm_domains_parse_states(), which parses and converts the > > > hierarchically described domain idle states from DT, into regular flattened > > > cpuidle states. The converted states are added to the existing cpuidle > > > driver's array of idle states, which make them available for cpuidle. > > > > > And what's the main motivation for this if OSI is not supported in the > > firmware ? > > Hi Sudeep, > > Main motivation is to do last-man activities before the CPU cluster can > enter a deep idle state. > Details on those last-man activities will help the discussion. Basically I am wondering what they are and why they need to done in OSPM ? > > > Signed-off-by: Ulf Hansson > > > [applied to new path, resolved conflicts] > > > Signed-off-by: Maulik Shah > > > --- > > > drivers/cpuidle/cpuidle-psci-domain.c | 137 +++++++++++++++++++++++++++++----- > > > drivers/cpuidle/cpuidle-psci.c | 41 +++++----- > > > drivers/cpuidle/cpuidle-psci.h | 11 +++ > > > 3 files changed, 153 insertions(+), 36 deletions(-) > > > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > > index 423f03b..3c417f7 100644 > > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > > @@ -26,13 +26,17 @@ struct psci_pd_provider { > > > }; > > > > > > static LIST_HEAD(psci_pd_providers); > > > -static bool osi_mode_enabled __initdata; > > > +static bool osi_mode_enabled; > > > > > > static int psci_pd_power_off(struct generic_pm_domain *pd) > > > { > > > struct genpd_power_state *state = &pd->states[pd->state_idx]; > > > u32 *pd_state; > > > > > > + /* If we have failed to enable OSI mode, then abort power off. */ > > > + if ((psci_has_osi_support()) && !osi_mode_enabled) > > > + return -EBUSY; > > > + > > Why is this needed ? IIUC we don't create genpd domains if OSI is not > > enabled. > > we do create genpd domains, for cpu domains, we just abort power off here > since idle states are converted into regular flattened mode. > OK, IIRC the OSI patches from Ulf didn't add the genpd or rather removed them in case of any failure to enable OSI. Has that been changed ? If so, why ? > however genpd poweroff will be used by parent domain (rsc in this case) > which is kept in hireachy in DTSI with cluster domain to do last man > activities. > I am bit confused here. Either we do OSI or PC and what you are describing sounds like a mix-n-match to me and I am totally against it. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel