From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B06BC35247 for ; Tue, 4 Feb 2020 15:58:55 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D27432084E for ; Tue, 4 Feb 2020 15:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D27432084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 851AF86A14; Tue, 4 Feb 2020 15:58:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WjkaDIGXPTZ3; Tue, 4 Feb 2020 15:58:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 6AC0586BA1; Tue, 4 Feb 2020 15:58:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 511D8C0177; Tue, 4 Feb 2020 15:58:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2DB4C0174 for ; Tue, 4 Feb 2020 15:58:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8B6BD86BA1 for ; Tue, 4 Feb 2020 15:58:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kY+xaBlcfIOg for ; Tue, 4 Feb 2020 15:58:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3E0F386A14 for ; Tue, 4 Feb 2020 15:58:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id AD07768C7B; Tue, 4 Feb 2020 16:58:45 +0100 (CET) Date: Tue, 4 Feb 2020 16:58:45 +0100 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 2/2] dma-direct: improve DMA mask overflow reporting Message-ID: <20200204155845.GA8839@lst.de> References: <20200204063205.652456-1-hch@lst.de> <20200204063205.652456-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: iommu@lists.linux-foundation.org, Christoph Hellwig , Konrad Rzeszutek Wilk X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Feb 04, 2020 at 03:14:06PM +0000, Robin Murphy wrote: >> @@ -371,7 +359,10 @@ dma_addr_t dma_direct_map_page(struct device *dev, struct page *page, >> if (swiotlb_force != SWIOTLB_NO_FORCE) >> return swiotlb_map(dev, phys, size, dir, attrs); >> - report_addr(dev, dma_addr, size); >> + dev_err_once(dev, >> + "DMA addr %pad+%zu overflow (mask %llx, bus limit %llx).\n", >> + &dma_addr, size, *dev->dma_mask, dev->bus_dma_limit); >> + WARN_ON_ONCE(1); > > Or even dev_WARN_ONCE() to make them even simpler? It looks like dev_WARN_ONCE supports format strings (unlike WARN_ON_ONCE), so that sounds fine. If there are no other comments coming in I'll apply the patches with that change. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu