From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EEEC35247 for ; Tue, 4 Feb 2020 17:15:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDFC721582 for ; Tue, 4 Feb 2020 17:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QQ+r7Ouw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727414AbgBDRPy (ORCPT ); Tue, 4 Feb 2020 12:15:54 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:28240 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727310AbgBDRPy (ORCPT ); Tue, 4 Feb 2020 12:15:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580836553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQ7t1k7i0wkmBvdxQkpvy0eDXYy8cnc2qnOKIbY4C8E=; b=QQ+r7OuwAdIrOHRWxRc6lyCvT2hVIXzoDcohjxm0L7w4AwmtyxiNxd4pmLzn1O8jhMptSR 20Jn7AZuM/NKdzHvH/TeZTOsmDoaTIw/oH5Zk+TCG9QOWbiEZYuZ2OWHqYiNiMeThrkarB RJpUDbtoCzxKVD7HInEjDtHeRKiDc+k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-yZMjxtnoNWi-6iF6-6-Zvg-1; Tue, 04 Feb 2020 12:15:49 -0500 X-MC-Unique: yZMjxtnoNWi-6iF6-6-Zvg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0677800D54; Tue, 4 Feb 2020 17:15:47 +0000 (UTC) Received: from gondolin (ovpn-117-199.ams2.redhat.com [10.36.117.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5AA38EA0C; Tue, 4 Feb 2020 17:15:39 +0000 (UTC) Date: Tue, 4 Feb 2020 18:15:37 +0100 From: Cornelia Huck To: Christian Borntraeger Cc: Janosch Frank , KVM , David Hildenbrand , Thomas Huth , Ulrich Weigand , Claudio Imbrenda , Andrea Arcangeli Subject: Re: [RFCv2 27/37] KVM: s390: protvirt: Only sync fmt4 registers Message-ID: <20200204181537.5f6bc2ce.cohuck@redhat.com> In-Reply-To: <20200203131957.383915-28-borntraeger@de.ibm.com> References: <20200203131957.383915-1-borntraeger@de.ibm.com> <20200203131957.383915-28-borntraeger@de.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 3 Feb 2020 08:19:47 -0500 Christian Borntraeger wrote: > From: Janosch Frank > > A lot of the registers are controlled by the Ultravisor and never > visible to KVM. Also some registers are overlayed, like gbea is with > sidad, which might leak data to userspace. > > Hence we sync a minimal set of registers for both SIE formats and then > check and sync format 2 registers if necessary. > > Also we disable set/get one reg for the same reason. It's an old > interface anyway. Didn't you already do that in the previous patch? > > Signed-off-by: Janosch Frank > Signed-off-by: Christian Borntraeger > [Fixes and patch splitting] > --- > arch/s390/kvm/kvm-s390.c | 116 ++++++++++++++++++++++++--------------- > 1 file changed, 72 insertions(+), 44 deletions(-)