From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF94C35247 for ; Tue, 4 Feb 2020 19:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 698B220674 for ; Tue, 4 Feb 2020 19:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727389AbgBDTyC (ORCPT ); Tue, 4 Feb 2020 14:54:02 -0500 Received: from cloud.peff.net ([104.130.231.41]:52352 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727314AbgBDTyC (ORCPT ); Tue, 4 Feb 2020 14:54:02 -0500 Received: (qmail 11051 invoked by uid 109); 4 Feb 2020 19:54:02 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 04 Feb 2020 19:54:02 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 2314 invoked by uid 111); 4 Feb 2020 20:02:14 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 04 Feb 2020 15:02:14 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 4 Feb 2020 14:54:01 -0500 From: Jeff King To: Han-Wen Nienhuys Cc: Han-Wen Nienhuys via GitGitGadget , git , Han-Wen Nienhuys Subject: Re: [PATCH v2 5/5] Reftable support for git-core Message-ID: <20200204195401.GB12705@coredump.intra.peff.net> References: <721201269df47dc2e406e4091ab6b18a4a59b65f.1580134944.git.gitgitgadget@gmail.com> <20200128073100.GA563058@coredump.intra.peff.net> <20200129104754.GE4218@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Feb 04, 2020 at 08:06:57PM +0100, Han-Wen Nienhuys wrote: > On Wed, Jan 29, 2020 at 11:47 AM Jeff King wrote: > > > That said, it might make for easier debugging if the reftables file > > declares the size it assumes. > > If there is a mismatch in size, the reftable will look completely > corrupted data. I think this will be a bad experience. Yes, but I think it would take a bunch of other failures to get there. And it's true of all of the other parts of Git, too; the master switch is a config setting that says "I'm a sha-256 repository". That said, I'm not at all opposed to a header in the reftables file saying "I'm a sha-256 reftable". We shouldn't ever see a mismatch there, but that's what I meant by "easier debugging". -Peff