From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix the docs for intel_set_cdclk_post_plane_update()
Date: Tue, 4 Feb 2020 22:26:20 +0200 [thread overview]
Message-ID: <20200204202620.GE13686@intel.com> (raw)
In-Reply-To: <b587253bd7d48edbce7b678a0d7fbf5958f2284a.camel@intel.com>
On Tue, Feb 04, 2020 at 06:18:09PM +0000, Souza, Jose wrote:
> On Tue, 2020-02-04 at 17:48 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > s/before/after/ again after accidentally changing it the
> > other way in commit 5604e9ceaed5 ("drm/i915: Simplify
> > intel_set_cdclk_{pre,post}_plane_update() calling convention")
> >
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index 7154a2288310..3ad5f36447e9 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct
> > intel_atomic_state *state)
> > * intel_set_cdclk_post_plane_update - Push the CDCLK state to the
> > hardware
> > * @state: intel atomic state
> > *
> > - * Program the hardware before updating the HW plane state based on
> > the
> > + * Program the hardware after updating the HW plane state based on
> > the
> > * new CDCLK state, if necessary.
>
> But the HW plane state will be updated later in dev_priv-
> >display.commit_modeset_enables().
That comes before intel_set_cdclk_post_plane_update().
>
> > */
> > void
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-04 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 15:48 [Intel-gfx] [PATCH] drm/i915: Fix the docs for intel_set_cdclk_post_plane_update() Ville Syrjala
2020-02-04 18:18 ` Souza, Jose
2020-02-04 20:26 ` Ville Syrjälä [this message]
2020-02-04 20:30 ` Souza, Jose
2020-02-05 4:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-07 9:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204202620.GE13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.