From mboxrd@z Thu Jan  1 00:00:00 1970
From: Oliver Graute <oliver.graute@gmail.com>
Date: Wed, 5 Feb 2020 09:48:02 +0100
Subject: [RFC 1/2] hack to boot with 2020.01
In-Reply-To: <20200204170711.GL13379@bill-the-cat>
References: <20200203135619.10180-1-oliver.graute@kococonnector.com>
 <20200203135619.10180-2-oliver.graute@kococonnector.com>
 <20200204170711.GL13379@bill-the-cat>
Message-ID: <20200205084802.GB9493@optiplex>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/02/20, Tom Rini wrote:
> On Mon, Feb 03, 2020 at 01:59:14PM +0000, Oliver Graute wrote:
> > As proposed here:
> > 
> > https://lists.denx.de/pipermail/u-boot/2020-January/396749.html
> > 
> > Both of my imx8qm boards (Advantech and Congatec) aren't booting
> > 2020.01 without this change. Whats the proper way to fix this on my side?
> >
> > ---
> >  drivers/core/device.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/core/device.c b/drivers/core/device.c
> > index 4e037083a6..8358051d60 100644
> > --- a/drivers/core/device.c
> > +++ b/drivers/core/device.c
> > @@ -395,11 +395,8 @@ int device_probe(struct udevice *dev)
> >  
> >  	if (CONFIG_IS_ENABLED(POWER_DOMAIN) && dev->parent &&
> >  	    (device_get_uclass_id(dev) != UCLASS_POWER_DOMAIN) &&
> > -	    !(drv->flags & DM_FLAG_DEFAULT_PD_CTRL_OFF)) {
> > -		ret = dev_power_domain_on(dev);
> > -		if (ret)
> > -			goto fail;
> > -	}
> > +	    !(drv->flags & DM_FLAG_DEFAULT_PD_CTRL_OFF))
> > +		dev_power_domain_on(dev);
> >  
> >  	ret = uclass_pre_probe_device(dev);
> >  	if (ret)
> 
> Adding Lokesh and quoting him from
> http://patchwork.ozlabs.org/patch/1211325/
> 
> "Can you check by not returning on failure here? If yes then check the
> power-domain/driver that is failing. If any driver doesn't expect core
> to enable power-domain then enable DM_FLAG_DEFAULT_PD_CTRL_OFF in the
> respective driver."

I tried, if I'am not returning on failure here. U-Boot boots well and
any logging shows me a return value 0 for dev_power_domain_on(). As soon
as I add the if statement with the goto fail U-Boot is stuck and I don't
see any msg on the uart neither return value for dev_power_domain_on.

So currently I can't tell which power-domain driver cause the issue.

Best Regards,

Oliver